SPEC file : https://github.com/chkumar246/horizon-tempest-plugin-distgit/blob/rpm-master/python-horizon-tests-tempest.spec SRPM Link : https://chandankumar.fedorapeople.org/python-horizon-tests-tempest-0.0.1-0.20160712194144.5378f71.el7.centos.src.rpm RPM : https://chandankumar.fedorapeople.org/python-horizon-tests-tempest-0.0.1-0.20160712194144.5378f71.el7.centos.noarch.rpm
Spec URL: https://raw.githubusercontent.com/chkumar246/horizon-tempest-plugin-distgit/rpm-master/python-horizon-tests-tempest.spec SRPM URL: https://chandankumar.fedorapeople.org/python-horizon-tests-tempest-0.0.1-0.20160712194144.5378f71.el7.centos.src.rpm Description: This package contains Tempest tests to cover the Horizon project. Additionally it provides a plugin to automatically load these tests into tempest.
rpmlint complains about: python-horizon-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into tempest. => wrap that line python-horizon-tests-tempest.noarch: E: no-changelogname-tag => not used on rpm-master, can be ignore python-horizon-tests-tempest.noarch: W: no-documentation => add %doc README.rst, it has useful information
Spec URL: https://raw.githubusercontent.com/chkumar246/horizon-tempest-plugin-distgit/rpm-master/python-horizon-tests-tempest.spec SRPM: https://chandankumar.fedorapeople.org/horizon/python-horizon-tests-tempest-0.0.1-0.20160719045323.5378f71.el7.centos.src.rpm Thanks, Chandan Kumar
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. in /home/apevec/src/rdo/python-horizon-tests-tempest/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. Note: changelog is empty on rpm-master [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: DLRN inserts %define upstream-version, TODO fix in RDO tooling [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-horizon-tests-tempest-0.0.1-0.20160719045323.5378f71.fc25.noarch.rpm python-horizon-tests-tempest-0.0.1-0.20160719045323.5378f71.fc25.src.rpm python-horizon-tests-tempest.noarch: E: no-changelogname-tag python-horizon-tests-tempest.src: E: no-changelogname-tag Note: changelog is empty on rpm-master python-horizon-tests-tempest.src: W: invalid-url Source0: tempest-horizon-0.0.1.dev7-0.20160719045323.5378f71.tar.gz Note: generated from git on rpm-master, no upstream releases yet 2 packages and 0 specfiles checked; 2 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- python-horizon-tests-tempest.noarch: E: no-changelogname-tag 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Requires -------- python-horizon-tests-tempest (rpmlib, GLIBC filtered): python(abi) python-babel python-oslo-config python-oslo-log python-pbr python-six Provides -------- python-horizon-tests-tempest: python-horizon-tests-tempest python2.7dist(tempest-horizon) Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 --rpm-spec -b 1355886 Buildroot used: fedora-rawhide-x86_64
Please proceed with https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk
Package is now built in RDO Trunk, we can close this bug.