Created attachment 1179212 [details] Screen shot reference for the reported issue. Description of problem: When clicking 'Release Notes' link on RHEVM welcome page with de_DE locale, the information message appeared on corresponding page is "Die Deutsch Dokumentation scheint nicht installiert zu sein...". Here "Deutsch" must be changed to "deutsche" but not available on zanata to update the same. Version-Release number of selected component (if applicable): Version 4.0.2-0.2.rc1.el7ev How reproducible: Steps to Reproduce: 1. Access the RHEVM welcome page with de_DE locale. 2. Click on 'Release Notes' link. 3. Observe the information message appeared on the corresponding page. Actual results: Message has "Deutsch" Expected results: Message should have "deutsche" Additional info: Screen-shot attached for reference.
I cannot find this string in Zanata. What is the English version of the message? I used 4.1.0.3-0.1.el7 to check it but I could not reproduce the message.
Hi Krishna, I was able to see the page after clearing cache/cookies. I located the string in Zanata. File: backend/manager/modules/docs/src/main/resources/messages Source: It appears that you do not have the {0} documentation installed. Target: Die {0} Dokumentation scheint nicht installiert zu sein. Obviously, the word "Deutsch" is mapped to the variable {0} but I am not able to locate it within this project. The translation must be located somewhere else. The source code is here: https://github.com/oVirt/ovirt-engine/blob/e06859fef6c38a955a4e0e1f6b0ddaa1e8eae8fb/backend/manager/modules/docs/src/main/resources/messages.properties by Alex @Alex, could you please take a look at this bug?
@Yuko, That variable is resolved using the Java locale system. It basically contains objects that return text form when you pass in for instance de_DE. I misused that variable in the message. I think the best option would be to have the text translated, but if I put English in the English message, I am not sure if the translators would actually translate that (which is why I went with the locale object value in the first place). Any suggest on how I can hint to the translators to change 'English' to whatever locale they are working in?
Hi Alex, Tricky part is that only a single translator needs to translate their own locale name (so no point adding all lang names to Zanata, as if you do, those locale names will be translated into 7 languages). Is there a way to find more adequate locale object values that can be correctly used? (sorry, not much of help)
Yuko - I took another look at how the message is setup. There isn't another way to ask Java for a language's name in different grammatical usages. The only way to accommodate this BZ seems to be to: 1. change the wording on the message, and 2. change the comments in the property file so the comment hint in Zanata gives some context to the message. (I double checked - on a push, Zanata will take any comments directly above and attached to a key/message line and show it as a source comment on the UI) I propose rewording the message from "It appears that you do not have the {0} documentation installed." to "It appears that you do not have the local language documentation installed." Additionally, add the following comment for Zanata to display to translators - "NOTE: Message should directly reference the local language's name." With those 2 small changes, I think translators will know what to do and we don't have to rely on Java's "Display Language" to be grammatically correct.
Thank you very much for looking into it, Scott. To avoid misunderstanding by translators, it can be further changed to: "It appears that this document is not available in your language." What do you think?
I'll add a "currently" so the message also implies that it could be available in future.
Thank you very much, Scott.
Can this BZ moved to MODIFIED, or are additional patches are needed?
No other patches are needed, but it won't pass QA until the first translation update.
The translation cycle #1 was completed last week and I have confirmed that this string has been changed to "It appears that this document is not currently available in your language." and no longer uses the variable that caused the grammatical error. I have not verified the change on the UI yet but would this be sufficient to pass QA?
Created attachment 1347111 [details] fixed Thanks Yuko. I verified in UI too. (attached)
(In reply to Greg Sheremeta from comment #15) > Created attachment 1347111 [details] > fixed > > Thanks Yuko. I verified in UI too. (attached) Thank you Greg.
This message is actually deleted in 4.2 GA.
BZ<2>Jira Resync