Bug 1356172 - the message "snapshot created in different cluster version" is shown all the time
Summary: the message "snapshot created in different cluster version" is shown all the ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.0.4
: 4.0.4
Assignee: Marek Libra
QA Contact: sefi litmanovich
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-13 14:51 UTC by Tomas Jelinek
Modified: 2016-09-26 12:39 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-09-26 12:39:05 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.0.z+
rule-engine: planning_ack+
michal.skrivanek: devel_ack+
mavital: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 60704 0 master MERGED core: Fix overwriting originalClusterVersion 2016-08-30 11:22:07 UTC
oVirt gerrit 63019 0 ovirt-engine-4.0 MERGED core: Fix overwriting originalClusterVersion 2016-08-31 13:02:07 UTC
oVirt gerrit 63081 0 ovirt-engine-4.0.4 MERGED core: Fix overwriting originalClusterVersion 2016-08-31 16:29:56 UTC

Description Tomas Jelinek 2016-07-13 14:51:16 UTC
Reproduce:
- have a running VM
- create a snapshot with memory
- turn off the VM
- press preview

result: the "The selected snapshot's memory can't be properly restored since it was created in different cluster version. Please confirm the memory shall be restored anyway." is shown even the VM is still in the same cluster.

If you check the "restore anyway" checkbox the memory is restored and seems to be working properly.

Additional info:
The reason seems to be that the check in SnapshotModel.isVMWithMemoryCompatible() relies on the vm.getClusterCompatibilityVersionOrigin(); while SnapshotManager.updateVmFromConfiguration() replaces it by vm.setClusterCompatibilityVersionOrigin(oldVmStatic.getClusterCompatibilityVersionOrigin());

Comment 2 sefi litmanovich 2016-09-13 14:55:02 UTC
Verified with rhevm-4.0.4.2-0.1.el7ev.noarch.

The message did not appear when running the flow in the description.
The message did not appear when the vm was set with custom ccv 3.6 before taking the snapshot and set to custom ccv 4.0 after snapshot is taken and before previewing - this makes sense as in this case ccv is managed manually by the user.
The message did appear when snapshot was created on a 3.6 cluster and was previewed after the cluster's upgrade to 4.0 ccv.


Note You need to log in before you can comment on or make changes to this bug.