Bug 1356232 - Executables being renamed within .spec file
Summary: Executables being renamed within .spec file
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: hfsplus-tools
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adam Jackson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-13 18:45 UTC by Mattia Verga
Modified: 2016-10-06 16:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-06 16:48:24 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Mattia Verga 2016-07-13 18:45:17 UTC
I've asked kde-partitionmanager developer to switch using hfsplusutils in favor of hfsplus-tools (which is Fedora preferred and required from other packages), but I've just realized that I cannot make it work because hfplus-tools executables are renamed within the .spec file: newfs_hfs is renamed to mkfs.hfsplus and fsck_hfs is renamed to fsck.hfsplus

Is there a reason for that?

Comment 1 Jan Kurik 2016-07-26 04:03:09 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 2 Mattia Verga 2016-08-04 07:15:32 UTC
Would be possible to use symlinks instead of renaming executables?
See https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/SGEID67HKC4GIHFROEWAONBHC5RE4TCO/

Comment 3 Richard W.M. Jones 2016-08-04 08:45:00 UTC
Yes, please leave the mkfs.hfsplus & fsck.{hfs,hfsplus} programs
in place, either hard linking or as symlinks.  Otherwise you will
break 'fsck -t hfs', 'mkfs -t hfsplus' etc etc.

Really upstream is broken here.

Comment 4 Richard W.M. Jones 2016-08-04 08:48:30 UTC
FWIW the Debian package renames the executables when installing,
same as Fedora:

override_dh_auto_install:
        dh_testdir
        dh_testroot
        dh_prep
        dh_installdirs

        install -m 644 newfs_hfs.tproj/hfsbootdata.img $(shrdir)/hfsbootdata
        install -m 755 newfs_hfs.tproj/newfs_hfs   $(tmpdir)/sbin/mkfs.hfsplus
        install -m 755 fsck_hfs.tproj/fsck_hfs     $(tmpdir)/sbin/fsck.hfsplus
        install -m 644 newfs_hfs.tproj/newfs_hfs.8 $(mandir)/mkfs.hfsplus.8
        install -m 644 fsck_hfs.tproj/fsck_hfs.8   $(mandir)/fsck.hfsplus.8

Comment 5 Mattia Verga 2016-10-06 16:48:24 UTC
I've asked upstream to use the renamed executables, since other distributions do the same as Fedora.

So, no need to change anything in hfsplus-tools.


Note You need to log in before you can comment on or make changes to this bug.