Bug 1356475 - RHEV VM Reconfigure: Hot unplug CPU and Hot add memory request succeed, though it should fail on not-supported
Summary: RHEV VM Reconfigure: Hot unplug CPU and Hot add memory request succeed, thoug...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: GA
: 5.8.0
Assignee: Juan Hernández
QA Contact: Ilanit Stein
URL:
Whiteboard: rhev
Depends On:
Blocks: 1431808
TreeView+ depends on / blocked
 
Reported: 2016-07-14 08:23 UTC by Ilanit Stein
Modified: 2017-06-12 17:15 UTC (History)
8 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1431808 (view as bug list)
Environment:
Last Closed: 2017-06-12 17:15:38 UTC
Category: ---
Cloudforms Team: RHEVM
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Ilanit Stein 2016-07-14 08:23:23 UTC
Description of problem:
When trying to Hot unplug CPU along with Memory hot add,
the cpu hot plug operation fail on RHEV side (not supported), and the Memory new value seem to not propagated correctly to RHEV,
however on CFME side this request succeed.

For example, 
For a VM with sockets=4, cores per socket=1, and memory=100M, guaranteed memory=100M, 
VM reconfigure: CPU sockets 4->1, and memory 100M->256M.

This request succeed:
VM Reconfigure for: vm - Memory: 256 MB, Processor Sockets: 1, Processor Cores Per Socket: 1, Total Processors: 1
Last Message VM Reconfigure complete

On RHEV side, the CPU un plug hot plug fail on not supported succeed, and the memory hot add fail on value not being a multiply of 256M (though the value entered on CFME side was 256M), therefore it seems the memory new value was not passed correctly to RHEV.

RHEV Events:
Jul 14, 2016 6:57:18 AM
VM vm configuration was updated by admin@internal.
601a7d1a
oVirt

Jul 14, 2016 6:57:18 AM
Failed to hot set number of CPUS to VM vm. Underlying error message: Hot un-plugging a CPU is not supported for cluster version 3.6 and architecture x86_64.
4389ee6d
oVirt

Jul 14, 2016 6:57:18 AM
VM vm was configured with 100mb of memory while the recommended value range is 256mb - 65536mb
oVirt

Jul 14, 2016 6:57:18 AM
VM vm configuration was updated by admin@internal.
64f7b766
oVirt

Jul 14, 2016 6:57:18 AM
Failed to hot set memory to VM vm. Underlying error message: Cannot hot set memory VM. Plugged memory must be multiplication of 256.

Version-Release number of selected component (if applicable):
CFME 5.6.0.11-rc2.2.20160614152915_f315c68
RHEVM-3.6.6.2-0.1.el6

How reproducible:
100%


Actual results:
1. The request for setting CPU hot Unplug & Memory hot add together, Succeed.
2. Memory hot add value is not propagated correctly to RHEV, if done along with CPU hot plug.

Expected results:
1. The request for setting CPU hot plug & Memory hot add together, should Fail, 
if one of these operations fail (in this case both operations failed),
and the errors from RHEV should be propagated from RHEV (and displayed in the request result)  
2. Memory hot add value should be passed correctly to RHEV, if done along with CPU hot plug, but this is handled in bug 1356468.

Comment 2 Ilanit Stein 2016-11-07 15:16:28 UTC
Retested on CFME-5.7.0.9 (appliance leased from Sprout)
and RHV-4.0.4

VM Reconfigure:  cpu sockets 4->1, memory 100M->256M

CFME request failed:
Description VM Reconfigure for: test_hot - Memory: 256 MB, Processor Sockets: 1, Processor Cores Per Socket: 1, Total Processors: 1
Last Message Error: [Cannot edit VM. Physical Memory Guaranteed cannot exceed Memory Size.]

RHV VM event:  Failed to hot set memory to VM test_hot. Underlying error message: Cannot hot set memory VM. Plugged memory must be multiplication of 256.

The VM was not updated.

Comment 3 Juan Hernández 2016-11-10 13:34:07 UTC
The following pull requests should address this issue:

  Add support for matrix parameters to update memory
  https://github.com/ManageIQ/ovirt/pull/72

  Adjust memory reconfiguration for oVirt
  https://github.com/ManageIQ/manageiq/pull/12550

Comment 4 Ilanit Stein 2016-11-13 10:54:46 UTC
The patches in comment 3 address the problems of:
- VM memory hot plug fail on RHV side on the restriction of 256 multiply.
- Failure of [Cannot edit VM. Physical Memory Guaranteed cannot exceed Memory Size.]

But it do not resolve the problem of VM cpu un plug, failing on RHV-3.6 (as it is  not supported), but pass on CFME side.

I guess the root cause here is that RHV do not report this as a failure,
and thus on CFME the request pass.

On RHV side, the CPU hot unplug will be set on the VM's next run. 

Juan,
Can you please address this issue?

Comment 5 Juan Hernández 2016-11-29 07:58:48 UTC
Moti, if I remember correctly we decided to not fix the CPU un plug for 3.6, can you confirm?

Comment 6 Moti Asayag 2016-11-29 13:59:33 UTC
(In reply to Juan Hernández from comment #5)
> Moti, if I remember correctly we decided to not fix the CPU un plug for 3.6,
> can you confirm?

Confirmed. I added a DOC_TEXT on Bug 1356468 for this issue.

Comment 8 Juan Hernández 2017-01-09 17:03:51 UTC
This isn't fixed in the 'master' branch.

Comment 9 Oved Ourfali 2017-03-13 08:39:41 UTC
Juan - this should be at least on POST, right?
Wasn't it on the 5.8.0 build?

Comment 10 Juan Hernández 2017-03-13 09:43:53 UTC
Yes, it has been merged and backported, moving to POST.

Comment 11 Satoe Imaishi 2017-03-13 14:12:15 UTC
Juan, is https://github.com/ManageIQ/manageiq/pull/12550 the last PR needed for this BZ?

Comment 12 Juan Hernández 2017-03-13 18:47:56 UTC
Yes Satoe, I believe that is the last PR needed.

Comment 14 Ilanit Stein 2017-04-23 11:04:10 UTC
Verified on CFME-5.8.0.11/RHV-4.0.7:

VM Reconfigure:  cpu sockets 4->1, memory 100M->256M
CFME request succeed.
On RHV side, VM memory updated to 356 MB (as expected, memory delta is rounded to 256MB),
and CPU hot unplug failed on:

"Hot un-plugging a CPU is not supported for cluster version 4.0 and architecture x86_64."

As this bug do not handle the cpu hot unplug, and it will documented,
according to comment #6, moving bug to verified.


Note You need to log in before you can comment on or make changes to this bug.