Bug 1356502 - rubygem-grit: test suite is success without test files.
Summary: rubygem-grit: test suite is success without test files.
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-grit
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 907393
TreeView+ depends on / blocked
 
Reported: 2016-07-14 09:28 UTC by Jun Aruga
Modified: 2016-07-20 07:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-20 07:54:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jun Aruga 2016-07-14 09:28:02 UTC
Description of problem:

rubygem-grit has a test suite logic in check section of rpm spec file.
But actually its test suite is not set in the directory.
You can get unit test files from github.

Version-Release number of selected component (if applicable):
rubygem-grit-2.5.0-3


How reproducible:

Steps to Reproduce:
1. mock -r fedora-rawhide-x86_64 rubygem-grit-2.5.0-3.fc25.src.rpm

2. <mock-chroot> sh-4.3# ls -l /builddir/build/BUILD/rubygem-grit-2.5.0/usr/share/gems/gems/grit-2.5.0/test
ls: cannot access '/builddir/build/BUILD/rubygem-grit-2.5.0/usr/share/gems/gems/grit-2.5.0/test': No such file or directory

Actual results:

test is success without any test files.

Expected results:

test is success with test files.


Additional info:

Refer a rubygem-activesupport case URL.
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-activesupport.git/tree/rubygem-activesupport.spec

I want to update rubygem-grit because I wanted to use rubygem-mime-types 3.1, which is depended from rubygem-grit.
https://bugzilla.redhat.com/show_bug.cgi?id=907393

I tried to fix test suite on upstream. but not yet.
https://github.com/junaruga/grit/tree/feature/pass-test-suite

Actually the upstream has retired to maintain it.
So, I think that it is optional to retire this rpm package to solve this program.

Comment 1 Jun Aruga 2016-07-14 09:37:52 UTC
I suppose that the upstream recommends rugged [1], and we have rubygem-rugged package [2].
So, I think we can retire this rubygem-grit rpm package.

[1] https://github.com/mojombo/grit
> Grit is no longer maintained. Check out rugged.

[2] https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-rugged/

Comment 2 Joe Vlcek 2016-07-14 13:26:00 UTC
Please retire rubygem-grit

Comment 3 Jun Aruga 2016-07-14 14:25:46 UTC
(In reply to Joe Vlcek from comment #2)
> Please retire rubygem-grit

Okay, thanks for your replying.

Comment 4 Vít Ondruch 2016-07-15 07:27:45 UTC
(In reply to Joe Vlcek from comment #2)
> Please retire rubygem-grit

Joe, you are the only one who can do that. I tried to retire the package using my proven-packager privileges, but unfortunately "fedpkg retire" denied my request with "Could not retire package: You are not allowed to retire this package." message.

Comment 5 Jun Aruga 2016-07-18 11:36:01 UTC
(In reply to Joe Vlcek from comment #2)
> Please retire rubygem-grit

Joe, could you retire by yourself?

Comment 6 Fedora Admin XMLRPC Client 2016-07-19 13:14:41 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 7 Joe Vlcek 2016-07-19 13:21:34 UTC
Moving Status to POST. Please let me know if this is not the correct Status flow.

Comment 8 Fedora Admin XMLRPC Client 2016-07-20 07:50:40 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 9 Fedora Admin XMLRPC Client 2016-07-20 07:52:00 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 10 Vít Ondruch 2016-07-20 07:54:37 UTC
Thx Joe, that was actually good move with orphaning of the package. I took it end was able to retire it properly.


Note You need to log in before you can comment on or make changes to this bug.