Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1356568

Summary:	VM CPU hot plug along with memory hot add, leave VM pending SOUND change.
Product:	[oVirt] ovirt-engine	Reporter:	Ilanit Stein <istein>
Component:	Backend.Core	Assignee:	Shmuel Melamud <smelamud>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Israel Pinto <ipinto>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	---	CC:	bugs, gklein, istein, lsurette, mgoldboi, michal.skrivanek, rbalakri, Rhev-m-bugs, smelamud, srevivo, tjelinek, ykaul
Target Milestone:	ovirt-4.0.5	Flags:	rule-engine: ovirt-4.0.z+ mgoldboi: planning_ack+ tjelinek: devel_ack+ mavital: testing_ack+
Target Release:	4.0.5
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-18 07:36:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ilanit Stein 2016-07-14 11:58:37 UTC

Description of problem:
When configuring both memory hot add, and CPU hot plug (Cores 1->2),
From CFME, these changes reach the VM, and the VM is configured correctly, but the VM is marked with a delta sign. Edit VM, and press OK, show:
 
"Changes that require Virtual Machine restart:
 SOUND"
Though this parameter was not touched.

Version-Release number of selected component (if applicable):
RHEVM-3.6.6.2-0.1.el6

Expected results:
SOUND parameter should not appear as Pending VM changes.

Comment 1 Michal Skrivanek 2016-07-15 06:20:22 UTC

I suppose this doesn't reproduce from RHEV UI, then it is a CFME bug. Please confirm (also might want to use latest 3.6.8 instead of 3.6.6)

Comment 2 Ilanit Stein 2016-07-17 10:17:33 UTC

This reproduce from RHEV UI.
Moved to RHEVM-3.6.8-2, and still see it.

Narrowed the bug, as followed: 

* For a running VM, with Other OS (also has disk with no OS installed), 

Memory hot add, and CPU hot plug 
(Do not choose apply later for memory/cpu changes), 
press OK -> VM marked with a Delta.
Edit VM & Press OK,   
Open this dialog:
"Changes that require Virtual Machine restart:
 SOUND"

* For a VM, (named cfme_additional") that has a disk installed with RHEL-7.2,

Memory hot add (8192->8448 MB), and CPU hot plug (Cores: 1->2, while sockets=1),  
(Do not choose apply later for memory/cpu changes), 
press OK -> VM marked with a Delta.
Edit VM (see that Memory/CPU updated with the new values) & Press OK,   

VM has these events, following this Edit VM:

VM cfme_additional CFME_downstream_20160615_Disk1 disk was updated by admin@internal.

VM cfme_additional configuration was updated by admin@internal.

On VM's general tab found this info:
Number of CPU Cores:
1 (1:1:1 Sockets:Cores/S.:Threads/C.)

Comment 3 Michal Skrivanek 2016-07-18 12:56:01 UTC

Shmuel, thoughts?

Comment 4 Shmuel Melamud 2016-07-19 11:27:01 UTC

I can reproduce this on 3.6 and on master also. Additional requirement to reproduce: sound card must be enabled before the first step.

Seems to be a bug in the frontend.

Comment 5 Sandro Bonazzola 2016-08-31 12:39:51 UTC

Moving back to POST since there's no backport to 4.0.z branches in gerrit.
Please be sure to keep the bug in consistent state.

Comment 6 Tomas Jelinek 2016-09-09 06:41:57 UTC

it was not backported to 4.0.4 - moving to 4.0.5 as modified.

Comment 7 Israel Pinto 2016-10-05 11:40:25 UTC

Verify with:
Engine Version: 4.0.5-0.1.el7ev
Host: 
OS Version:RHEL - 7.3 - 6.el7
OS Description:Red Hat Enterprise Linux Server 7.3 Beta (Maipo)
Kernel Version:3.10.0 - 510.el7.x86_64
KVM Version:2.6.0 - 27.el7
LIBVIRT Version:libvirt-2.0.0-10.el7
VDSM Version:vdsm-4.18.13-1.el7ev
SPICE Version:0.12.4 - 19.el7

Steps:
1. Create VM with 1 GB memory and 1 CPU.
2. Start VM
3. Hotplug Memory with 1GB and CPU with to 2 CPU
4. Hotplug Memory with 256M and CPU with to 4 CPU

Results:
Memory and CPU are updated, and in the next run dialog the sound card not appear any more.