Spec URL: https://gil.fedorapeople.org/ldaptive.spec SRPM URL: https://gil.fedorapeople.org/ldaptive-1.1.0-1.fc23.src.rpm Description: Ldaptive is a simple, extensible Java API for interacting with LDAP servers. It was designed to provide easy LDAP integration for application developers. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14893630
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ------ - There is a BSD licensed file: core/src/main/java/org/ldaptive/io/Base64.java You'll need to add it to License tag, include the license file and notify upstream that they have a differently licensed file without documenting it. Or alternatively, you can remove it and replace its usages with Java 8 Base64. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 688 files have unknown license. Detailed output of licensecheck in /home/msimacek/reviews/1356596-ldaptive/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ldaptive-beans , ldaptive-javadoc , ldaptive-json , ldaptive-parent , ldaptive-templates [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ldaptive-1.1.0-1.fc25.noarch.rpm ldaptive-beans-1.1.0-1.fc25.noarch.rpm ldaptive-javadoc-1.1.0-1.fc25.noarch.rpm ldaptive-json-1.1.0-1.fc25.noarch.rpm ldaptive-parent-1.1.0-1.fc25.noarch.rpm ldaptive-templates-1.1.0-1.fc25.noarch.rpm ldaptive-1.1.0-1.fc25.src.rpm ldaptive-beans.noarch: W: no-documentation ldaptive-json.noarch: W: no-documentation ldaptive-parent.noarch: W: no-documentation ldaptive-templates.noarch: W: spelling-error %description -l en_US Templating -> Contemplating, Template, Tempting ldaptive-templates.noarch: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- ldaptive-beans.noarch: W: no-documentation ldaptive-templates.noarch: W: spelling-error %description -l en_US Templating -> Contemplating, Template, Tempting ldaptive-templates.noarch: W: no-documentation ldaptive-json.noarch: W: no-documentation ldaptive-parent.noarch: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- ldaptive-beans (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.ldaptive:ldaptive) ldaptive-templates (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.ldaptive:ldaptive) mvn(org.ldaptive:ldaptive-json) mvn(org.springframework:spring-beans) mvn(org.springframework:spring-context) mvn(org.springframework:spring-core) ldaptive-json (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.googlecode.json-simple:json-simple) mvn(org.ldaptive:ldaptive) ldaptive-parent (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.felix:maven-bundle-plugin) mvn(org.apache.maven.plugins:maven-checkstyle-plugin) mvn(org.apache.maven.plugins:maven-compiler-plugin) mvn(org.apache.maven.plugins:maven-jar-plugin) ldaptive (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(commons-cli:commons-cli) mvn(org.slf4j:slf4j-api) ldaptive-javadoc (rpmlib, GLIBC filtered): javapackages-tools Provides -------- ldaptive-beans: ldaptive-beans mvn(org.ldaptive:ldaptive-beans) mvn(org.ldaptive:ldaptive-beans:pom:) osgi(org.ldaptive.beans) ldaptive-templates: ldaptive-templates mvn(org.ldaptive:ldaptive-templates) mvn(org.ldaptive:ldaptive-templates:pom:) osgi(org.ldaptive.templates) ldaptive-json: ldaptive-json mvn(org.ldaptive:ldaptive-json) mvn(org.ldaptive:ldaptive-json:pom:) osgi(org.ldaptive.json) ldaptive-parent: ldaptive-parent mvn(org.ldaptive:ldaptive-parent:pom:) ldaptive: ldaptive mvn(org.ldaptive:ldaptive) mvn(org.ldaptive:ldaptive:pom:) osgi(org.ldaptive) ldaptive-javadoc: ldaptive-javadoc Source checksums ---------------- https://github.com/vt-middleware/ldaptive/archive/v1.1.0/ldaptive-1.1.0.tar.gz : CHECKSUM(SHA256) this package : 9ffb43f8719128598f4f633c1c1e2985454bfa1c88f2e4c2abe466bae2891dc2 CHECKSUM(SHA256) upstream package : 9ffb43f8719128598f4f633c1c1e2985454bfa1c88f2e4c2abe466bae2891dc2 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1356596 Buildroot used: rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Michael Simacek from comment #1) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ------ > - There is a BSD licensed file: > core/src/main/java/org/ldaptive/io/Base64.java > You'll need to add it to License tag, include the license file and notify > upstream that they have a differently licensed file without documenting it. > Or alternatively, you can remove it and replace its usages with Java 8 > Base64. Done, migbase64 Base64 was remove for the next release Spec URL: https://gil.fedorapeople.org/ldaptive.spec SRPM URL: https://gil.fedorapeople.org/ldaptive-1.1.0-1.fc23.src.rpm
Great. APPROVED
Thanks for the review! create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/6430 https://admin.fedoraproject.org/pkgdb/package/requests/6431
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/ldaptive
(In reply to Jon Ciesla from comment #5) > Package request has been approved: > https://admin.fedoraproject.org/pkgdb/package/rpms/ldaptive thanks!
ldaptive-1.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ee3fb47b3c
ldaptive-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ee3fb47b3c
ldaptive-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.