Bug 1356642 - Po-send-mail in po-mode doesn't work with emacs 25
Summary: Po-send-mail in po-mode doesn't work with emacs 25
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gettext
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daiki Ueno
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-14 14:43 UTC by Göran Uddeborg
Modified: 2016-08-27 10:44 UTC (History)
4 users (show)

Fixed In Version: gettext-0.19.8.1-2.fc24 gettext-0.19.8.1-2.fc25
Clone Of:
Environment:
Last Closed: 2016-08-12 19:27:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Göran Uddeborg 2016-07-14 14:43:48 UTC
Description of problem:
After upgrading to the emacs version of F25, po-send-mail no longer works.  Normally it creates a buffer with an appropriate e-mail header and a base64 encoded body.  But now the entire buffer gets base64 encoded.  Not surprisingly, the mail functions don't know what to do with that afterwards.

I believe this is because of the use of "(region-beginning)" near line 3525 in po-mode.el.  Probably something that used to set the mark in previous emacs version doesn't do so any more, or possibly the other way around.  To fix this, I changed the save-excursion part of the function to look like below.  That appears to make things work again.  Someone with more emacs lisp skills than I have is welcome to comment if this is a good way to do it.

            (save-excursion
              (let
                  ((beginning (point)))
                (insert-buffer-substring buffer)
                (shell-command-on-region
                 beginning (region-end)
                 (concat po-gzip-uuencode-command " " name ".gz") t t)))))))


Version-Release number of selected component (if applicable):
emacs-25.0.94-1.fc24.x86_64
emacs-gettext-0.19.8.1-1.fc24.noarch


How reproducible:
Every time


Steps to Reproduce:
1. Open a po file in emacs
2. Hit "M"
3. Answer the questions


Actual results:
A buffer completely base64 encoded.


Expected results:
A buffer with a legal mail header, and a base64 encoded body.


Additional info:
I've sent this report upstreams too: http://lists.gnu.org/archive/html/bug-gettext/2016-07/msg00027.html

Comment 1 Fedora Update System 2016-08-10 11:28:19 UTC
gettext-0.19.8.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c058ebd5c2

Comment 2 Fedora Update System 2016-08-10 11:28:30 UTC
gettext-0.19.8.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f2443e5bb9

Comment 3 Fedora Update System 2016-08-10 18:55:14 UTC
gettext-0.19.8.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c058ebd5c2

Comment 4 Fedora Update System 2016-08-11 03:24:21 UTC
gettext-0.19.8.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f2443e5bb9

Comment 5 Fedora Update System 2016-08-12 19:27:48 UTC
gettext-0.19.8.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2016-08-27 10:43:58 UTC
gettext-0.19.8.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.