Bug 135669 (IT_71111) - tcsendbreak fails in compat mode
Summary: tcsendbreak fails in compat mode
Keywords:
Status: CLOSED ERRATA
Alias: IT_71111
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel
Version: 4.0
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Jason Baron
QA Contact: Brian Brock
URL:
Whiteboard:
Depends On:
Blocks: 154907 156322
TreeView+ depends on / blocked
 
Reported: 2004-10-14 09:36 UTC by Gordon Jin
Modified: 2013-03-06 05:57 UTC (History)
4 users (show)

Fixed In Version: RHSA-2005-514
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-05 12:30:48 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
compat_ioctl_tcsbrkp.patch (2.28 KB, patch)
2004-11-11 01:31 UTC, Gordon Jin
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2005:514 0 qe-ready SHIPPED_LIVE Important: Updated kernel packages available for Red Hat Enterprise Linux 4 Update 2 2005-10-05 04:00:00 UTC

Description Gordon Jin 2004-10-14 09:36:10 UTC
Description of problem:
ioctl TCSBRKP is needed for POSIX tcsendbreak().  
But arch/x86_64/ia32 doesn't support TCSBRKP.
So x86 application calling tcsendbreak() will fail on x86_64 with 
compat mode.

How reproducible:
Always

Steps to Reproduce:
Run an x86 program calling tcsendbreak() in compat mode.
E.g. LTP case ptem01 uses tcsendbreak(), which calls ioctl(3, 
TCSBRKP, 0x1). 
  
Actual results:
The call failed.

Expected results:
The call should succeed.

Comment 1 Gordon Jin 2004-10-14 09:41:24 UTC
I'll post the patch later.
The solution to add TCSBRKP in arch/x86_64/ia32/ia32_ioctl.c is 
simple. 
But better we need discuss with other compat archs to see if it's OK 
to moving it to compat_ioctl.c.

Comment 2 Gordon Jin 2004-11-11 01:31:45 UTC
Created attachment 106465 [details]
compat_ioctl_tcsbrkp.patch

This patch fixes.
It's already sent to community, and will probably go into mainstream soon.

Comment 3 Gordon Jin 2004-12-02 17:36:22 UTC
How about including this patch in RHEL4?

Comment 4 Keve Gabbert 2005-01-31 09:22:53 UTC
Gordon, has this patch been accepted upstream?

Comment 5 Gordon Jin 2005-02-01 03:20:01 UTC
I just checked and found the answer is no. It looks like it is 
dropped somehow. I'm pushing again.

Comment 6 Gordon Jin 2005-03-09 08:05:03 UTC
This patch has been in mainline tree:
http://linux.bkbits.net:8080/linux-2.5/cset@1.2020.4.114

Please apply.

Comment 18 Red Hat Bugzilla 2005-10-05 12:30:48 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2005-514.html



Note You need to log in before you can comment on or make changes to this bug.