Description of problem: In glibc-2.23 on Fedora 25/rawhide (glibc-2.23.90), the readdir_r() function is marked as deprecated and compiler warnings are emitted while compiling. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Created attachment 1180163 [details] full compile output with deprecated warnings
REVIEW: http://review.gluster.org/14838 (core: use readdir(3) with glibc, and associated cleanup) posted (#9) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/14838 (core: use readdir(3) with glibc, and associated cleanup) posted (#10) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/14838 (core: use readdir(3) with glibc, and associated cleanup) posted (#11) for review on master by Kaleb KEITHLEY (kkeithle)
COMMIT: http://review.gluster.org/14838 committed in master by Jeff Darcy (jdarcy) ------ commit 561746080b0b7154bfb3bdee20d426cf2ef7db17 Author: Kaleb S. KEITHLEY <kkeithle> Date: Thu Jul 7 08:51:08 2016 -0400 core: use readdir(3) with glibc, and associated cleanup Starting with glibc-2.23 (i.e. what's in Fedora 25), readdir_r(3) is marked as deprecated. Specifically the function decl in <dirent.h> has the deprecated attribute, and now warnings are thrown during the compile on Fedora 25 builds. The readdir(_r)(3) man page (on Fedora 25 at least) and World+Dog say that glibc's readdir(3) is, and always has been, MT-SAFE as long as only one thread is accessing the directory object returned by opendir(). World+Dog also says there is a potential buffer overflow in readdir_r(). World+Dog suggests that it is preferable to simply use readdir(). There's an implication that eventually readdir_r(3) will be removed from glibc. POSIX has, apparently deprecated it in the standard, or even removed it entirely. Over and above that, our source near the various uses of readdir(_r)(3) has a few unsafe uses of strcpy()+strcat(). (AFAIK nobody has looked at the readdir(3) implemenation in *BSD to see if the same is true on those platforms, and we can't be sure of MacOS even though we know it's based on *BSD.) Change-Id: I5481f18ba1eebe7ee177895eecc9a80a71b60568 BUG: 1356998 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> Reviewed-on: http://review.gluster.org/14838 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> CentOS-regression: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Kotresh HR <khiremat> Reviewed-by: Jeff Darcy <jdarcy>