Bug 1357017 - rubygem-sup: Support mime-types-3.1 too
Summary: rubygem-sup: Support mime-types-3.1 too
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-sup
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-15 13:36 UTC by Jun Aruga
Modified: 2016-07-29 08:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-29 04:15:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Supports rubygem-mime-types 3.1 too as a dependency (1.26 KB, patch)
2016-07-15 13:46 UTC, Jun Aruga
no flags Details | Diff

Description Jun Aruga 2016-07-15 13:36:43 UTC
Description of problem:

Hi,
Current version rubygem-sup supports mime-types 1.x.
However I want to update mime-types to 3.1 that is likely to be used by Rails 5.
So, I will upload the patch for that.
I have tested its new rubygem-sup for both mime-types 1.25.1 and 3.1.

I am going to upload the patch file soon on next comment.


Version-Release number of selected component (if applicable): 0.21.0-4


Additional info:

rubygem-mime-types 3.1 is here.
https://copr.fedorainfracloud.org/coprs/vondruch/ror5/package/rubygem-mime-types/

rubygem-sup that is built with rubygem-mime-types 3.1 is here.
https://copr.fedorainfracloud.org/coprs/vondruch/ror5/package/rubygem-sup/

Comment 1 Jun Aruga 2016-07-15 13:46:27 UTC
Created attachment 1180164 [details]
Supports rubygem-mime-types 3.1 too as a dependency

I uploaded the patch?
Could you check this?

Comment 2 Jun Aruga 2016-07-15 14:28:18 UTC
> > rubygem-sup that is built with rubygem-mime-types 3.1 is here.
> https://copr.fedorainfracloud.org/coprs/vondruch/ror5/package/rubygem-sup/

I have deleted rubygem-sup from above copr, as its page is not suitable.

Comment 3 Jun Aruga 2016-07-18 11:48:03 UTC
I am planning to update rubygem-mime-types to 3.1 on rawhide.
The current version rubygem-sup must fail the build on rawhide after that.
So, you can use my uploaded patch here to fix the build failure for the current version.
Thanks.

Comment 4 Jan Kurik 2016-07-26 05:04:31 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 5 Dan Callaghan 2016-07-29 02:52:37 UTC
Thanks for the patch.

Rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=786324
F25: http://koji.fedoraproject.org/koji/buildinfo?buildID=786325

Seems like mime-types 3.1 was pushed to F24 as well so this will need an update for F24...

Comment 6 Dan Callaghan 2016-07-29 04:13:43 UTC
(In reply to Dan Callaghan from comment #5)
> Seems like mime-types 3.1 was pushed to F24 as well so this will need an
> update for F24...

Oops no that is wrong. So this doesn't need an F24 update. However I have already built for F24... I guess I will just untag the build and let it expire, there's no actual harm in having this relaxed requirement on F24 but there's also no reason to bother pushing out an update for it either.

Comment 7 Jun Aruga 2016-07-29 08:11:26 UTC
Thanks for your accepting my patch.
Yes, the mime-types 3.1 is for not f24 but only f25 and rawhide.
Because it was needed for Rails5 released on f25.
Okay. No problem!

(In reply to Dan Callaghan from comment #6)
> (In reply to Dan Callaghan from comment #5)
> > Seems like mime-types 3.1 was pushed to F24 as well so this will need an
> > update for F24...
> 
> Oops no that is wrong. So this doesn't need an F24 update. However I have
> already built for F24... I guess I will just untag the build and let it
> expire, there's no actual harm in having this relaxed requirement on F24 but
> there's also no reason to bother pushing out an update for it either.


Note You need to log in before you can comment on or make changes to this bug.