Bug 1358432 - Storage allocation table in New VM dialog has shifted columns
Summary: Storage allocation table in New VM dialog has shifted columns
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.0.2
: 4.0.2
Assignee: Daniel Erez
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-20 16:28 UTC by jniederm
Modified: 2016-08-12 14:24 UTC (History)
5 users (show)

Fixed In Version: ovirt-engine-4.0.2.2
Clone Of:
Environment:
Last Closed: 2016-08-12 14:24:35 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.0.z+
rule-engine: exception+
rule-engine: planning_ack+
rule-engine: devel_ack+
acanan: testing_ack+


Attachments (Terms of Use)
screenshot (50.51 KB, image/png)
2016-07-20 16:28 UTC, jniederm
no flags Details
edit-pool-redundant-disk-allocation-table-header (45.47 KB, image/png)
2016-07-21 13:04 UTC, jniederm
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 61333 0 master MERGED webadmin: removed redundant source column header 2016-07-26 11:25:04 UTC
oVirt gerrit 61397 0 ovirt-engine-4.0 MERGED webadmin: removed redundant source column header 2016-07-26 19:40:19 UTC
oVirt gerrit 61399 0 ovirt-engine-4.0.2 MERGED webadmin: removed redundant source column header 2016-07-26 19:40:50 UTC

Description jniederm 2016-07-20 16:28:34 UTC
Created attachment 1182171 [details]
screenshot

Description of problem:
Columns' width don't correspond to width of header cells. Content of 'Disk Profile' column seems to be completely missing.


Version-Release number of selected component (if applicable):
4.1 master, commit d1c81eb

How reproducible:
100%

Steps to Reproduce:
1. Webadmin:
2. Make sure there is a template with disk
3. Open New VM dialog
4. Select a template with disk
5. Select Resource Allocation tab and scroll down

Actual results:
Disk allocation table has wider regular cells that header cells

Expected results:
All cells in each column have same width.

Additional info:

Comment 1 Allon Mureinik 2016-07-21 12:45:05 UTC
yuck. let's try to solve this for 4.

Comment 2 jniederm 2016-07-21 13:04:37 UTC
Created attachment 1182492 [details]
edit-pool-redundant-disk-allocation-table-header

Comment 3 jniederm 2016-07-21 13:10:25 UTC
There is another problem with disk allocation table. It's header is redundantly shown in Edit pool dialog of pool without disks. See attachment 1182492 [details].

Steps to reproduce:
1. Create a pool without disks.
2. Edit it
3. Go to Resource Allocation tab, scroll down

Actual result:
Redundant header is shown.

Version:
4.0 master, commit 9c88731

Comment 4 Allon Mureinik 2016-07-26 11:30:30 UTC
This patch still needs to be backported to ovirt-engine-4.0 and ovirt-engine-4.0.2.

Comment 6 Allon Mureinik 2016-08-01 11:01:44 UTC
This is already merged in 4.0.2.

Comment 7 Kevin Alon Goldblatt 2016-08-03 13:03:57 UTC
Tested with the following code:
----------------------------------------
rhevm-4.0.2.3-0.1.el7ev.noarch
vdsm-4.18.9-1.el7ev.x86_64


Tested with the following scenario:

Steps to Reproduce:
1. Webadmin:
2. Make sure there is a template with disk
3. Open New VM dialog
4. Select a template with disk
5. Select Resource Allocation tab and scroll down

Actual results:
All cells in each column have same width.


Moving to VERIFIED!


Note You need to log in before you can comment on or make changes to this bug.