RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1358615 - [RFE] Provide additional options for bridge configuration.
Summary: [RFE] Provide additional options for bridge configuration.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.2
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: 7.4
Assignee: Beniamino Galvani
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks: 1420851 1470965 1473733 1491322
TreeView+ depends on / blocked
 
Reported: 2016-07-21 07:21 UTC by Andreas Bleischwitz
Modified: 2020-04-15 14:34 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1491322 (view as bug list)
Environment:
Last Closed: 2018-04-10 13:19:11 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
[NM patch] bridge: introduce a bridge.group-forward-mask connection property (12.17 KB, patch)
2017-07-24 08:28 UTC, Beniamino Galvani 		no flags Details | Diff
[nm-c-e patch] bridge: add support for group-forward-mask property (5.19 KB, patch)
2017-07-24 08:32 UTC, Beniamino Galvani 		no flags Details | Diff
[nm-c-e patch v2] bridge: add support for group-forward-mask property (7.00 KB, patch)
2017-08-30 07:59 UTC, Beniamino Galvani 		no flags Details | Diff
[PATCH] tui: add group-forward-mask property to bridge page (1.23 KB, patch)
2017-10-06 12:39 UTC, Beniamino Galvani 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0778 0 None None None 2018-04-10 13:21:22 UTC

Description Andreas Bleischwitz 2016-07-21 07:21:38 UTC 
- Proposed title of this feature request
Add Bridging options provided by kernel to NetworkManager configuration

- What is the nature and description of the request?
- Why does the customer need this? (List the business requirements here)
Customer currently configures his RHEL7 systems using NetworkManager which also seem to be the preferred way. As security guidelines enforces him to use 802.1x EAP for each network-connection and he uses this system to host Windows-VMs on that machine, he has to set "group_fwd_mask" option of the bridge to 0x8. See https://access.redhat.com/solutions/1201263 in this regards. Unfortunately NetworkManager has no option to set this value, so the customer has to use the previously preferred way of setting parameters in /etc/sysconfig/network-scripts/ifcfg-*.

      
- How would the customer like to achieve this? (List the functional requirements)
As this required option is just one of many, I would suggest to create a more generic interface which scans /sys/class/net/*/bridge/* for write-able files and provides a way to change the parameters found in that directory. That way this RFE would be future safe as new options would automatically be configurable.
Integration into UI (nmtui.nm-connection-editor) does not yet need to be provided. nmcli should be able to set these options.

- For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.

nmcli con show <bridge> should list the options with bridge.* as it does now with some parameters.

nmcli con edit <bridge>
nmcli> goto bridge
You may edit the following properties: mac-address, stp, priority, forward-delay, hello-time, max-age, ageing-time,.... (whatever is found writeable in /s/c/n/*/b/)

nmcli bridge> set group_fwd_mask 8

nmcli bridge> print # should print the updated value

- Is there already an existing RFE upstream or in Red Hat Bugzilla?  
None found

- Does the customer have any specific timeline dependencies and which release would they like to target (i.e. RHEL5, RHEL6)?
None known

- Is the sales team involved in this request and do they have any additional input?
no

- List any affected packages or components.
NetworkManager
NetworkManager-libnm
NetworkManager-tui if options should also be configurable by TUI.

- Would the customer be able to assist in testing this functionality if implemented?
Yes
Comment 5 Beniamino Galvani 2017-07-22 07:13:26 UTC 
> - How would the customer like to achieve this? (List the functional requirements)
> As this required option is just one of many, I would suggest to create
> a more generic interface which scans /sys/class/net/*/bridge/* for
> write-able files and provides a way to change the parameters found in
> that directory. That way this RFE would be future safe as new options
> would automatically be configurable.  Integration into UI
> (nmtui.nm-connection-editor) does not yet need to be provided. nmcli
> should be able to set these options.

While providing a generic interface for setting options discovered at
runtime would help with new bridge options that are needed in the
future, unfortunately this doesn't fit very well the current
NetworkManager model.

First, NetworkManager must understand the meaning of the specific
options to perform syntax validation and checking of dependencies
between them. This is similar to what we do for bonds, where some
options must be applied in a specific order and some exclude
others. Applying the parameters in the wrong order means that some
will not have effect.

Also, reading /sys/class/net/*/bridge/* requires that a bridge is
already present in the system, which is not always the case when you
want to edit/create a new connection.

Integration in the UI (including nmcli and nmtui) would also be a
problem if NM doesn't understand the options, because the UI could
only provide a field where users can enter whatever they want without
any validation, which generally represents a bad user experience.

So, I believe it's better if we add a new property for each bridge
option that is needed. I understand that this bugzilla is about the
"group_fwd_mask" option; do you have any other ones in mind that could
be useful?

Thanks.
Comment 6 Andreas Bleischwitz 2017-07-24 07:33:22 UTC 
Thanks Beniamino for the explanation. Makes sense.

From our current requirements "group_fwd_mask" would be sufficient. Reading https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-net, I could not imagine any other important option which is not already covered.
Comment 7 Beniamino Galvani 2017-07-24 08:28:14 UTC 
Created attachment 1303510 [details]
[NM patch] bridge: introduce a bridge.group-forward-mask connection property
Comment 8 Beniamino Galvani 2017-07-24 08:32:57 UTC 
Created attachment 1303512 [details]
[nm-c-e patch] bridge: add support for group-forward-mask property
Comment 9 Lubomir Rintel 2017-07-26 16:22:36 UTC 
Both the NM & the editor patches look good to me.
Comment 10 Thomas Haller 2017-07-26 16:42:51 UTC 
lgtm too
Comment 11 Beniamino Galvani 2017-07-27 07:46:35 UTC 
Applied to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=17ec3aef2fa4d31ef80f54923f89e6719f1ce83b

https://git.gnome.org/browse/network-manager-applet/commit/?id=4a780cc25d69d2dce983a218f5eb435b696a86df
Comment 12 Thomas Haller 2017-08-21 09:44:44 UTC 
(In reply to Beniamino Galvani from comment #11)
> https://git.gnome.org/browse/network-manager-applet/commit/?id=4a780cc25d69d2dce983a218f5eb435b696a86df

I reverted the patch in applet, because it breaks build:
https://git.gnome.org/browse/network-manager-applet/commit/?id=3721371ee8b9762725ddd163204fdaa086812b33
Comment 13 Beniamino Galvani 2017-08-30 07:59:23 UTC 
Created attachment 1319895 [details]
[nm-c-e patch v2] bridge: add support for group-forward-mask property
Comment 14 Beniamino Galvani 2017-09-01 08:07:29 UTC 
nm-connection-editor v2 patch applied to master:

https://git.gnome.org/browse/network-manager-applet/commit/?id=4f5a4d3a8b75f0d60f8124f59dcdcfe8e2888c05
Comment 17 Beniamino Galvani 2017-10-06 12:39:33 UTC 
Created attachment 1335308 [details]
[PATCH] tui: add group-forward-mask property to bridge page

Add missing support in nmtui.
Comment 18 Thomas Haller 2017-10-10 14:26:08 UTC 
(In reply to Beniamino Galvani from comment #17)
> Created attachment 1335308 [details]
> [PATCH] tui: add group-forward-mask property to bridge page
> 
> Add missing support in nmtui.

lgtm
Comment 19 Beniamino Galvani 2017-10-13 12:22:40 UTC 
(In reply to Thomas Haller from comment #18)
> (In reply to Beniamino Galvani from comment #17)
> > Created attachment 1335308 [details]
> > [PATCH] tui: add group-forward-mask property to bridge page
> > 
> > Add missing support in nmtui.
> 
> lgtm

Applied to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=802116db43381f67b873e7e0283485c4ff035fc9
Comment 21 Vladimir Benes 2017-12-16 13:05:51 UTC 
3 tests added into CI test suite.
Comment 24 errata-xmlrpc 2018-04-10 13:19:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0778
Note You need to log in before you can comment on or make changes to this bug.