Bug 1359092 - Review Request: golang-gopkg-go-check-check - Rich testing extension for Go's testing package
Summary: Review Request: golang-gopkg-go-check-check - Rich testing extension for Go's...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-22 09:21 UTC by Zygmunt Krynicki
Modified: 2016-08-08 23:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-08 20:29:28 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Zygmunt Krynicki 2016-07-22 09:21:53 UTC
Spec URL: https://fedorapeople.org/~zyga/golang-gopkg-go-check-check.spec
SRPM URL: https://fedorapeople.org/~zyga/golang-gopkg-go-check-check-1-1.git4f90aea.fc24.src.rpm
Description: 
The Go language provides an internal testing library, named testing, which is
relatively slim due to the fact that the standard library correctness by
itself is verified using it. The check package, on the other hand, expects the
standard library from Go to be working correctly, and builds on it to offer a
richer testing framework for libraries and applications to use.

Fedora Account System Username: zyga

Comment 1 Neal Gompa 2016-07-22 09:25:23 UTC
Taking this review.

Comment 2 Neal Gompa 2016-07-22 10:33:22 UTC
Package was generated through gofed, so this review is quite a bit simpler.

- Conforms to packaging guidelines (gofed generated spec)
- license correct and valid
- only sources installed

The only issue I see is that the email address is missing in the %changelog entry. If you fix this when you import the package, then everything is fine.

Package approved.

Comment 3 Zygmunt Krynicki 2016-07-22 11:51:37 UTC
Thanks, noted on the %changelog, will do as suggested.

Thank you
ZK

Comment 4 Gwyn Ciesla 2016-07-22 13:14:19 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-gopkg-go-check-check

Comment 5 Fedora Update System 2016-07-25 12:52:11 UTC
golang-gopkg-go-check-check-1-1.git4f90aea.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-049cd2318e

Comment 6 Fedora Update System 2016-07-25 13:02:23 UTC
golang-gopkg-go-check-check-1-1.git4f90aea.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-515782ea97

Comment 7 Fedora Update System 2016-07-28 04:18:55 UTC
golang-gopkg-go-check-check-1-1.git4f90aea.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-515782ea97

Comment 8 Fedora Update System 2016-07-28 06:01:09 UTC
golang-gopkg-go-check-check-1-1.git4f90aea.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-049cd2318e

Comment 9 Fedora Update System 2016-08-08 20:29:25 UTC
golang-gopkg-go-check-check-1-1.git4f90aea.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-08-08 23:55:55 UTC
golang-gopkg-go-check-check-1-1.git4f90aea.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.