Bug 1359425 - [abrt] libselinux: write_binary_file(): sefcontext_compile killed by SIGSEGV
Summary: [abrt] libselinux: write_binary_file(): sefcontext_compile killed by SIGSEGV
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libselinux
Version: 24
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Lautrbach
QA Contact: Fedora Extras Quality Assurance
URL: https://retrace.fedoraproject.org/faf...
Whiteboard: abrt_hash:5299a465444257bb3467dc481b8...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-23 22:44 UTC by Peter "Pessoft" Kolínek
Modified: 2016-10-10 17:43 UTC (History)
4 users (show)

Fixed In Version: libselinux-2.5-12.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-10 17:43:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (68.95 KB, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: cgroup (276 bytes, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: core_backtrace (477 bytes, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: dso_list (735 bytes, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: exploitable (82 bytes, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: limits (1.29 KB, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: maps (3.64 KB, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: mountinfo (3.78 KB, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: namespaces (102 bytes, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: open_fds (289 bytes, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: proc_pid_status (1.07 KB, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details
File: var_log_messages (28 bytes, text/plain)
2016-07-23 22:44 UTC, Peter "Pessoft" Kolínek
no flags Details

Description Peter "Pessoft" Kolínek 2016-07-23 22:44:05 UTC
Description of problem:
Can be reproduced by executing:
semanage fcontext -a -t var_t '/myvar/*'

Version-Release number of selected component:
libselinux-2.5-9.fc24

Additional info:
reporter:       libreport-2.7.2
backtrace_rating: 4
cmdline:        /sbin/sefcontext_compile /etc/selinux/targeted/contexts/files/file_contexts.local
crash_function: write_binary_file
environ:        
executable:     /usr/sbin/sefcontext_compile
global_pid:     10001
kernel:         4.6.3-300.fc24.x86_64
pkg_fingerprint: 73BD E983 81B4 6521
pkg_vendor:     Fedora Project
runlevel:       N 5
type:           CCpp
uid:            0

Truncated backtrace:
Thread no. 1 (1 frames)
 #0 write_binary_file at sefcontext_compile.c:243

Comment 1 Peter "Pessoft" Kolínek 2016-07-23 22:44:12 UTC
Created attachment 1183195 [details]
File: backtrace

Comment 2 Peter "Pessoft" Kolínek 2016-07-23 22:44:14 UTC
Created attachment 1183196 [details]
File: cgroup

Comment 3 Peter "Pessoft" Kolínek 2016-07-23 22:44:15 UTC
Created attachment 1183197 [details]
File: core_backtrace

Comment 4 Peter "Pessoft" Kolínek 2016-07-23 22:44:17 UTC
Created attachment 1183198 [details]
File: dso_list

Comment 5 Peter "Pessoft" Kolínek 2016-07-23 22:44:19 UTC
Created attachment 1183199 [details]
File: exploitable

Comment 6 Peter "Pessoft" Kolínek 2016-07-23 22:44:20 UTC
Created attachment 1183200 [details]
File: limits

Comment 7 Peter "Pessoft" Kolínek 2016-07-23 22:44:22 UTC
Created attachment 1183201 [details]
File: maps

Comment 8 Peter "Pessoft" Kolínek 2016-07-23 22:44:23 UTC
Created attachment 1183202 [details]
File: mountinfo

Comment 9 Peter "Pessoft" Kolínek 2016-07-23 22:44:25 UTC
Created attachment 1183203 [details]
File: namespaces

Comment 10 Peter "Pessoft" Kolínek 2016-07-23 22:44:27 UTC
Created attachment 1183204 [details]
File: open_fds

Comment 11 Peter "Pessoft" Kolínek 2016-07-23 22:44:28 UTC
Created attachment 1183205 [details]
File: proc_pid_status

Comment 12 Peter "Pessoft" Kolínek 2016-07-23 22:44:30 UTC
Created attachment 1183206 [details]
File: var_log_messages

Comment 13 Petr Lautrbach 2016-07-24 07:49:12 UTC
Thanks for the report. It needs to be fixed.

However, the reproducer most likely doesn't use a correct expression. FILE_SPEC is processed as PCRE so unless you want ["/myvar", "/myvar/", "/myvar//", "/myvar///", ...]   it should be "/myvar/.*" or "/myvar(/.*)?" depends whether you want "/myvar" in the list or not.

Comment 14 Peter "Pessoft" Kolínek 2016-07-24 09:43:27 UTC
Indeed, FILE_SPEC expression which triggers this issue has been discovered only accidentally, by a typo in the custom script. Correct expression was "/myvar/*".

Comment 15 Peter "Pessoft" Kolínek 2016-07-24 09:44:18 UTC
(In reply to Peter "Pessoft" Kolínek from comment #14)
> Indeed, FILE_SPEC expression which triggers this issue has been discovered
> only accidentally, by a typo in the custom script. Correct expression was
> "/myvar/*".

:) "/myvar/.*"

Comment 16 Vit Mojzis 2016-08-26 13:13:32 UTC
The issue is solved on upstream and the fix will propagate to fedora branch during next rebase.

https://github.com/SELinuxProject/selinux/commit/6e2bdb770f6311060b111e87bd7af653e225be9d

Comment 17 Fedora Update System 2016-10-05 20:29:28 UTC
checkpolicy-2.5-8.fc25, libselinux-2.5-12.fc25, libsemanage-2.5-8.fc25, libsepol-2.5-10.fc25, policycoreutils-2.5-17.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b7e8e980ef

Comment 18 Fedora Update System 2016-10-06 20:59:00 UTC
checkpolicy-2.5-8.fc25, libselinux-2.5-12.fc25, libsemanage-2.5-8.fc25, libsepol-2.5-10.fc25, policycoreutils-2.5-17.fc25, secilc-2.5-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b7e8e980ef

Comment 19 Fedora Update System 2016-10-10 17:43:45 UTC
checkpolicy-2.5-8.fc25, libselinux-2.5-12.fc25, libsemanage-2.5-8.fc25, libsepol-2.5-10.fc25, policycoreutils-2.5-17.fc25, secilc-2.5-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.