Bug 1359652 – Fail to inspect Windows ISO file

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1359652 - Fail to inspect Windows ISO file

Summary:	Fail to inspect Windows ISO file

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	libguestfs (Show other bugs)
Sub Component:
Version:	7.3
Hardware:	x86_64 Linux

Priority	medium Severity medium
Target Milestone:	rc
Target Release:	---
Assigned To:	Richard W.M. Jones
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-07-25 04:47 EDT by Bin Han
Modified:	2016-11-03 14:02 EDT (History)
CC List:	4 users (show)

See Also:
Fixed In Version:	libguestfs-1.32.6-3.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-11-03 14:02:55 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
inspect-os log (13.36 KB, text/plain) 2016-07-25 04:47 EDT, Bin Han	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2016:2576	normal	SHIPPED_LIVE	Moderate: libguestfs and virt-p2v security, bug fix, and enhancement update	2016-11-03 08:06:51 EDT

Groups: None (edit)

Description Bin Han 2016-07-25 04:47:34 EDT

Created attachment 1183635 [details]
inspect-os log

Description of problem:
Fail to inspect Windows ISO file

Version-Release number of selected component (if applicable):
kernel 3.10.0-461.el7.x86_64
libguestfs-1.32.6-1.el7.x86_64
libosinfo-0.3.0-1.el7.x86_64


How reproducible:
Always

Steps to Reproduce:
1. download a Windows install ISO file.
2. Inspect the Windows iso as following:
#guestfish

><fs> add-ro en_windows_7_ultimate_with_sp1_x86_dvd_u_677460.iso
><fs> run
><fs> inspect-os
><fs>


Actual results:
At step2
><fs> inspect-os
Nothing output

Expected results:
At Step2
><fs> inspect-os
/dev/sda


Additional info:
1. If open debug mode to run guestfish -v -x , you can find this info "libguestfs: osinfo: /usr/share/libosinfo/db/oses: No such file or directory" after execute inspect-os which is shown as below.
#guestfish -v -x
><fs> add-ro en_windows_7_ultimate_with_sp1_x86_dvd_u_677460.iso
><fs> run
><fs> inspect-os
------debug info is omitted------------
libguestfs: osinfo: /usr/share/libosinfo/db/oses: No such file or directory
libguestfs: trace: mount_ro "/dev/sda" "/"
------debug info is omitted------------
><fs>

2.find windows xml file in other directory, so do the follow steps to copy the windows xml file into the place /usr/share/libosinfo/db/oses
   mkdir /usr/share/libosinfo/db/oses
   cp /usr/share/libosinfo/db/os/microsoft.com/win-7.xml /usr/share/libosinfo/db/oses/windows.xml
  After the windows.xml is in the right place, execute the command "inspect-os" again. It will get the right result.

Comment 2 Pino Toscano 2016-07-25 11:48:34 EDT

This is due to the different layout on disk of the (private) libosinfo database.
I just sent a patch to take care of the current new layout of libosinfo, and also of the upcoming shared osinfo database.

  https://www.redhat.com/archives/libguestfs/2016-July/msg00224.html

Comment 3 Pino Toscano 2016-07-26 07:20:40 EDT

Fixed with
https://github.com/libguestfs/libguestfs/commit/c2ae46a9ebcf9e6bd0037a5cc895095a255c1a24
which is in libguestfs >= 1.33.46.

Comment 5 Bin Han 2016-08-01 03:58:14 EDT

Verified with the packages:
libguestfs-1.32.6-2.el7.x86_64.rpm

Verify steps:
1. download a Windows install ISO file.
2. Inspect the Windows iso as following:
#guestfish

><fs> add-ro en_windows_7_ultimate_with_sp1_x86_dvd_u_677460.iso
><fs> run
><fs> inspect-os
/dev/sda
><fs> 

Get the right result. So verified.

Comment 6 Richard W.M. Jones 2016-08-03 07:19:26 EDT

Sorry, got to set this one back to ASSIGNED.

Pino added another fix for this:
https://github.com/libguestfs/libguestfs/commit/12c05d5c364c222854217c18a26d056ac2214b11

so I will include this in the next build and we need to retest this.

Comment 8 Xianghua Chen 2016-08-04 04:00:17 EDT

Verified with the packages:
libguestfs-1.33.46-1.el7.x86_64

Verify steps:
1. download a Windows install ISO file.
2. Inspect the Windows iso as following:
# guestfish -a en_windows_7_ultimate_with_sp1_x64_dvd_u_677332.iso run : inspect-os
/dev/sda


So verified.

Comment 10 errata-xmlrpc 2016-11-03 14:02:55 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2576.html

Note You need to log in before you can comment on or make changes to this bug.