Created attachment 1183635 [details] inspect-os log Description of problem: Fail to inspect Windows ISO file Version-Release number of selected component (if applicable): kernel 3.10.0-461.el7.x86_64 libguestfs-1.32.6-1.el7.x86_64 libosinfo-0.3.0-1.el7.x86_64 How reproducible: Always Steps to Reproduce: 1. download a Windows install ISO file. 2. Inspect the Windows iso as following: #guestfish ><fs> add-ro en_windows_7_ultimate_with_sp1_x86_dvd_u_677460.iso ><fs> run ><fs> inspect-os ><fs> Actual results: At step2 ><fs> inspect-os Nothing output Expected results: At Step2 ><fs> inspect-os /dev/sda Additional info: 1. If open debug mode to run guestfish -v -x , you can find this info "libguestfs: osinfo: /usr/share/libosinfo/db/oses: No such file or directory" after execute inspect-os which is shown as below. #guestfish -v -x ><fs> add-ro en_windows_7_ultimate_with_sp1_x86_dvd_u_677460.iso ><fs> run ><fs> inspect-os ------debug info is omitted------------ libguestfs: osinfo: /usr/share/libosinfo/db/oses: No such file or directory libguestfs: trace: mount_ro "/dev/sda" "/" ------debug info is omitted------------ ><fs> 2.find windows xml file in other directory, so do the follow steps to copy the windows xml file into the place /usr/share/libosinfo/db/oses mkdir /usr/share/libosinfo/db/oses cp /usr/share/libosinfo/db/os/microsoft.com/win-7.xml /usr/share/libosinfo/db/oses/windows.xml After the windows.xml is in the right place, execute the command "inspect-os" again. It will get the right result.
This is due to the different layout on disk of the (private) libosinfo database. I just sent a patch to take care of the current new layout of libosinfo, and also of the upcoming shared osinfo database. https://www.redhat.com/archives/libguestfs/2016-July/msg00224.html
Fixed with https://github.com/libguestfs/libguestfs/commit/c2ae46a9ebcf9e6bd0037a5cc895095a255c1a24 which is in libguestfs >= 1.33.46.
Verified with the packages: libguestfs-1.32.6-2.el7.x86_64.rpm Verify steps: 1. download a Windows install ISO file. 2. Inspect the Windows iso as following: #guestfish ><fs> add-ro en_windows_7_ultimate_with_sp1_x86_dvd_u_677460.iso ><fs> run ><fs> inspect-os /dev/sda ><fs> Get the right result. So verified.
Sorry, got to set this one back to ASSIGNED. Pino added another fix for this: https://github.com/libguestfs/libguestfs/commit/12c05d5c364c222854217c18a26d056ac2214b11 so I will include this in the next build and we need to retest this.
Verified with the packages: libguestfs-1.33.46-1.el7.x86_64 Verify steps: 1. download a Windows install ISO file. 2. Inspect the Windows iso as following: # guestfish -a en_windows_7_ultimate_with_sp1_x64_dvd_u_677332.iso run : inspect-os /dev/sda So verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-2576.html