Bug 1360327 – remove-ds.pl deletes an instance even if wrong prefix was specified

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1360327 - remove-ds.pl deletes an instance even if wrong prefix was specified

Summary:	remove-ds.pl deletes an instance even if wrong prefix was specified

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	389-ds-base (Show other bugs)
Sub Component:
Version:	7.3
Hardware:	Unspecified Unspecified

Priority	unspecified Severity low
Target Milestone:	pre-dev-freeze
Target Release:	7.3
Assigned To:	Noriko Hosoi
QA Contact:	Viktor Ashirov
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-07-26 08:32 EDT by Simon Pichugin
Modified:	2016-11-03 16:44 EDT (History)
CC List:	3 users (show)

See Also:
Fixed In Version:	389-ds-base-1.3.5.10-6.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-11-03 16:44:25 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2016:2594	normal	SHIPPED_LIVE	Moderate: 389-ds-base security, bug fix, and enhancement update	2016-11-03 08:11:08 EDT

Groups: None (edit)

Description Simon Pichugin 2016-07-26 08:32:42 EDT

Description of problem:
It is possible to delete the instance 'slapd-standalone' with remove-ds.pl tool, while specifying wrong prefix 'anyprefix-standalone'.

Version-Release number of selected component:
389-ds-base-1.3.5.10-5.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Install an instance with a name 'standalone'
2. Run remove-ds.pl tool to remove it, but specify a wrong prefix instead of 'slapd'
$ remove-ds.pl -i 'anyprefix-standalone'

Actual results:
Instance anyprefix-standalone removed.

Expected results:
The following errors occurred during removal:
Error: could not find directory server configuration directory 'anyprefix-standalone'.  Error: No such file or directory
Error: could not remove directory server standalone

Additional info:
/usr/sbin/remove-ds.pl contains the next line (50):
my ($slapd, $inst) = split(/-/, $instname, 2);

So it doesn't check that before '-' is 'slapd' prefix and then it just splits that part.

Comment 1 Noriko Hosoi 2016-07-26 12:24:00 EDT

Hi Simon,

Since remove-ds.pl is part of 389-ds-base, updating the Product and Component...

And you are very welcome to provide a git patch since you've already figured how to fix it. ;)  I'll review it and push it for you!

Thank you!!
--noriko

Comment 2 Noriko Hosoi 2016-07-26 12:25:17 EDT

Upstream ticket:
https://fedorahosted.org/389/ticket/48934

Comment 5 Simon Pichugin 2016-08-22 04:17:43 EDT

Build tested:
389-ds-base-1.3.5.10-8.el7.x86_64

Verification steps:
1. Install an instance with a name 'standalone'
2. Run remove-ds.pl tool to remove it, but specify a wrong prefix instead of 'slapd'

$ remove-ds.pl -i 'anyprefix-standalone'

Result:
Error: Invalid instance name "anyprefix-standalone"

$ remove-ds.pl -i 'slapd-standalone'

Result:
Instance slapd-standalone removed.

Marking as verified.

Comment 7 errata-xmlrpc 2016-11-03 16:44:25 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2594.html

Note You need to log in before you can comment on or make changes to this bug.