Bug 1360355 - Image upload: Upload image shows disk profile: null
Summary: Image upload: Upload image shows disk profile: null
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.0.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.1.2
: 4.1.2
Assignee: Liron Aravot
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-26 13:34 UTC by Natalie Gavrielov
Modified: 2017-05-23 08:12 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-23 08:12:23 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
rule-engine: devel_ack+
ratamir: testing_ack+


Attachments (Terms of Use)
snapshot (410.34 KB, image/png)
2016-07-26 13:34 UTC, Natalie Gavrielov
no flags Details
snapshot (188.90 KB, image/png)
2016-09-20 17:47 UTC, Natalie Gavrielov
no flags Details
ui.log (19.87 KB, text/plain)
2017-01-31 18:48 UTC, Natalie Gavrielov
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 73465 0 master MERGED webadmin: AbstractDiskModel - setDiskProfilesList() 2017-03-07 09:09:06 UTC
oVirt gerrit 73674 0 ovirt-engine-4.1 MERGED webadmin: AbstractDiskModel - setDiskProfilesList() 2017-03-07 13:53:52 UTC

Description Natalie Gavrielov 2016-07-26 13:34:29 UTC
Created attachment 1184276 [details]
snapshot

Description of problem:

This situation happened only once, for a reason I can't explain, disk profile shows in the drop down list a value "null". 

Version-Release number of selected component:
rhevm-4.0.2-0.1.rc.el7ev.noarch
ovirt-imageio-proxy-0.3.0-0.el7ev.noarch
ovirt-imageio-common-0.3.0-0.el7ev.noarch

How reproducible:
Was unable to reproduce yet.

Steps to Reproduce:
1. Go to disks tab, "Upload".
2. Fill in fields as in the snapshot attached.
3. Click on Disk options drop down list.

Actual results:
one of the options is null.

Expected results:
There is no such option as null.

Comment 1 Allon Mureinik 2016-07-27 11:36:42 UTC
Tentatively setting to 4.0.4 as we couldn't reproduce this either, yet. Natalie, if you find a good reproducer for this please share it here, and based on that we can consider pretargeting.

Comment 2 Raz Tamir 2016-08-01 11:53:35 UTC
See also https://bugzilla.redhat.com/show_bug.cgi?id=1361838

Comment 3 Allon Mureinik 2016-08-29 11:28:22 UTC
(In reply to Raz Tamir from comment #2)
> See also https://bugzilla.redhat.com/show_bug.cgi?id=1361838

Amit, won't the solution for bug 1361838 solve this one too?

Comment 4 Amit Aviram 2016-08-29 11:51:48 UTC
Seems it originates from the same problem, though it is required to take a deeper look.

Comment 5 Natalie Gavrielov 2016-09-20 17:47:54 UTC
Created attachment 1202990 [details]
snapshot

Happened again..
using the following builds:
rhevm-4.0.4.3-0.1.el7ev.noarch
ovirt-imageio-proxy-0.4.0-0.el7ev.noarch
ovirt-imageio-common-0.3.0-0.el7ev.noarch
vdsm-4.18.13-1.el7ev.x86_64
ovirt-imageio-daemon-0.4.0-0.el7ev.noarc

Comment 6 Amit Aviram 2016-09-28 14:59:39 UTC
(In reply to Natalie Gavrielov from comment #5)
> Created attachment 1202990 [details]
> snapshot
> 
> Happened again..
> using the following builds:
> rhevm-4.0.4.3-0.1.el7ev.noarch
> ovirt-imageio-proxy-0.4.0-0.el7ev.noarch
> ovirt-imageio-common-0.3.0-0.el7ev.noarch
> vdsm-4.18.13-1.el7ev.x86_64
> ovirt-imageio-daemon-0.4.0-0.el7ev.noarc

bug 1361838 merged to 4.0.4.4, can you update your env and see if the problem still exists? if not, 1361838 did solve this problem and the bug can be closed.

Comment 7 Liron Aravot 2017-01-08 12:26:16 UTC
Natalie, few questions -

1. When the window first opened - was the selected value null or did the value only appear when you clicked the drop down (or changed other drop downs selected values)

2. Do you recall how many profiles did you actually have for that domain?

Thanks,
Liron

Comment 8 Natalie Gavrielov 2017-01-16 12:34:21 UTC
(In reply to Liron Aravot from comment #7)
> Natalie, few questions -
> 
> 1. When the window first opened - was the selected value null or did the
> value only appear when you clicked the drop down (or changed other drop
> downs selected values)
> 
> 2. Do you recall how many profiles did you actually have for that domain?
> 
> Thanks,
> Liron

1. When opening the drop down list I saw the value null (it wasn't the default value).
2. I didn't configure any profiles, so it's the default one.. (so there was only one).

Comment 9 Daniel Erez 2017-01-23 09:29:47 UTC
Hi Natalie,

* Was there any error in browser console or ui.log when reproducing it?

* Is it still reproduced in latest build?

Comment 10 Natalie Gavrielov 2017-01-31 18:48:09 UTC
Created attachment 1246392 [details]
ui.log

(In reply to Daniel Erez from comment #9)
> Hi Natalie,
> 
> * Was there any error in browser console or ui.log when reproducing it?

No errors in browser console (I would have attached it if there were any)
ui.log didn't show anything interesting (attached). 

> * Is it still reproduced in latest build?
I haven't witnessed it recently

Comment 11 Liron Aravot 2017-02-07 18:31:19 UTC
As we didn't manage to reproduce (by modifying responses in debug mode as well) and the issue haven't reproduced lately - I'm closing as WORKSFORME, please reopen if it happens again.

Comment 12 Liron Aravot 2017-03-02 16:34:03 UTC
I managed to find the scenario to reproduce that issue: 
1. Attempt to perform disk upload
2. Fill a size bigger then the free space available on the selected domain, fill all the other fields as needed.
3. Click 'OK'
4. Error message will appear indicating there's not enough free space on the domain.
5. Select a different domain for the upload
6. null/empty (on 4.1) profile will appear.

Natalie, can you please verify that null appears on 4.0 on that scenario?

Comment 13 Natalie Gavrielov 2017-03-08 12:54:20 UTC
(In reply to Liron Aravot from comment #12)
> I managed to find the scenario to reproduce that issue: 
> 1. Attempt to perform disk upload
> 2. Fill a size bigger then the free space available on the selected domain,
> fill all the other fields as needed.
> 3. Click 'OK'
> 4. Error message will appear indicating there's not enough free space on the
> domain.
> 5. Select a different domain for the upload
> 6. null/empty (on 4.1) profile will appear.
> 
> Natalie, can you please verify that null appears on 4.0 on that scenario?

The scenario you descried here is not the one described in comment 0.

Comment 14 Liron Aravot 2017-03-08 13:02:52 UTC
I can see at least in the first screenshot, that indeed the provided size is larger than the free size (which aligns with the scenario I found).
However, as we didn't find another scenario to reproduce the issue - let's handle this scenario in this bz.
If we ever find another scenario causing this, we can open a new bug.

Regards,
Liron

Comment 15 Natalie Gavrielov 2017-03-08 14:09:39 UTC
(In reply to Liron Aravot from comment #14)
> I can see at least in the first screenshot, that indeed the provided size is
> larger than the free size (which aligns with the scenario I found).
> However, as we didn't find another scenario to reproduce the issue - let's
> handle this scenario in this bz.
> If we ever find another scenario causing this, we can open a new bug.
> 
> Regards,
> Liron

Agreed.

(In reply to Liron Aravot from comment #12)
> Natalie, can you please verify that null appears on 4.0 on that scenario?

I don't fully understand why you want me to verify what you already reproduced?

Comment 16 Liron Aravot 2017-03-08 14:18:03 UTC
I reproduced it on 4,1, I preferred to verify that the reproduction steps are relevant to v4.0 as well (so we can conclude that it's indeed the reproducer).

Comment 17 Natalie Gavrielov 2017-03-08 14:41:51 UTC
(In reply to Liron Aravot from comment #12)
> I managed to find the scenario to reproduce that issue: 
> 1. Attempt to perform disk upload
> 2. Fill a size bigger then the free space available on the selected domain,
> fill all the other fields as needed.
> 3. Click 'OK'
> 4. Error message will appear indicating there's not enough free space on the
> domain.
> 5. Select a different domain for the upload
> 6. null/empty (on 4.1) profile will appear.
> 
> Natalie, can you please verify that null appears on 4.0 on that scenario?


Tested the scenario described above on 4.0.7.4-0.1.el7ev
I do get the error message described in step 4, but there is no null/empty profile, so I was unable to recreate this.

Comment 18 Natalie Gavrielov 2017-04-30 11:40:50 UTC
Verified using scenario described in comment 12, rhevm-4.1.2-0.1.el7.noarch


Note You need to log in before you can comment on or make changes to this bug.