Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1360549

Summary:	afr coverity fixes
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.13	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.14	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1355604	Environment:
Last Closed:	2016-08-02 07:25:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1355604, 1360556
Bug Blocks:

Description Ravishankar N 2016-07-27 04:18:25 UTC

+++ This bug was initially created as a clone of Bug #1355604 +++

Description of problem:

Fixing some of the afr bugs reported by coverity that was run on  downstream code (RHGS 3.1.3). The entire report of the run is attached herewith.

--- Additional comment from Vijay Bellur on 2016-07-12 00:52:40 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-12 10:19:46 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-12 11:45:18 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#3) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-15 05:57:04 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#4) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-18 04:48:36 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#5) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-18 07:31:17 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#6) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-23 01:18:00 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#7) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-25 10:20:16 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#8) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-26 04:37:10 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#9) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-26 06:28:52 EDT ---

REVIEW: http://review.gluster.org/14895 (afr: some coverity fixes) posted (#10) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-07-26 13:06:56 EDT ---

COMMIT: http://review.gluster.org/14895 committed in master by Jeff Darcy (jdarcy) 
------
commit d1e2054974c5933771fe0e5626e2cd04bccc757a
Author: Ravishankar N <ravishankar>
Date:   Tue Jul 12 10:07:48 2016 +0530

    afr: some coverity fixes
    
    Thanks to Krutika for a cleaner way to track inode refs in
    afr_set_split_brain_choice().
    
    Change-Id: I2d968d05b815ad764b7e3f8aa9ad95a792b3c1df
    BUG: 1355604
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/14895
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Vijay Bellur 2016-07-27 04:21:39 UTC

REVIEW: http://review.gluster.org/15017 (afr: some coverity fixes) posted (#2) for review on release-3.7 by Ravishankar N (ravishankar)

Comment 2 Vijay Bellur 2016-07-28 13:54:40 UTC

COMMIT: http://review.gluster.org/15017 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit 53b54f1a03a5fb93266f66453d228258598f8ef6
Author: Ravishankar N <ravishankar>
Date:   Tue Jul 12 10:07:48 2016 +0530

    afr: some coverity fixes
    
    Backport of http://review.gluster.org/#/c/14895/
    
    Thanks to Krutika for a cleaner way to track inode refs in
    afr_set_split_brain_choice().
    
    Change-Id: I2d968d05b815ad764b7e3f8aa9ad95a792b3c1df
    BUG: 1360549
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/15017
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Kaushal 2016-08-02 07:25:06 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.14, please open a new bug report.

glusterfs-3.7.14 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-August/050319.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user