Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1360630

Summary:	[UI] - Exception when trying to break a bond with an unmanaged network attached to him
Product:	[oVirt] ovirt-engine	Reporter:	Michael Burman <mburman>
Component:	BLL.Network	Assignee:	Martin Mucha <mmucha>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Michael Burman <mburman>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.0.0	CC:	awels, bugs, danken, mburman, myakove, oourfali, ylavi
Target Milestone:	ovirt-4.1.0-beta	Flags:	rule-engine: ovirt-4.1+ ylavi: planning_ack+ danken: devel_ack+ myakove: testing_ack+
Target Release:	4.1.0.2
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-01 14:44:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Burman 2016-07-27 08:01:47 UTC

Description of problem:
[UI] - Exception when trying to break a bond with an unmanaged network attached to him. 
It's not possible to break the bond. 

webadmin-0.js:15456 Wed Jul 27 09:44:20 GMT+300 2016 
SEVERE: Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) 
 __gwt$exception: <skipped>: Cannot read property 'c' of null
	at Unknown._3p(webadmin-151.js@33)
	at Unknown.s4p(webadmin-151.js@24)
	at Unknown.S6p(webadmin-151.js@497550)
	at Unknown.A5p(webadmin-151.js@59)
	at Unknown.B5p(webadmin-151.js@496296)
	at Unknown.itl(webadmin-0.js@101)
	at Unknown.h5p(webadmin-151.js@124)
	at Unknown.E5p(webadmin-151.js@496449)
	at Unknown.A5p(webadmin-151.js@59)
	at Unknown.B5p(webadmin-151.js@496296)
	at Unknown.itl(webadmin-0.js@101)
	at Unknown.BXp(webadmin-151.js@412)
	at Unknown.Ydv(webadmin-151.js@36)
	at Unknown.Ofv(webadmin-151.js@755108)
	at Unknown.Qjf(webadmin-151.js@107189)
	at Unknown.Gy(webadmin-0.js@102)
	at Unknown.wy(webadmin-0.js@59)
	at Unknown.$x(webadmin-0.js@19)
	at Unknown.Zx(webadmin-0.js@177)
	at Unknown.eval(webadmin-0.js@54)
webadmin-0.js:15456 Wed Jul 27 09:44:20 GMT+300 2016 remote
SEVERE: Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) 
 __gwt$exception: <skipped>: Cannot read property 'c' of null
	at Unknown._3p(webadmin-151.js@33)
	at Unknown.s4p(webadmin-151.js@24)
	at Unknown.S6p(webadmin-151.js@497550)
	at Unknown.A5p(webadmin-151.js@59)
	at Unknown.B5p(webadmin-151.js@496296)
	at Unknown.itl(webadmin-0.js@101)
	at Unknown.h5p(webadmin-151.js@124)
	at Unknown.E5p(webadmin-151.js@496449)
	at Unknown.A5p(webadmin-151.js@59)
	at Unknown.B5p(webadmin-151.js@496296)
	at Unknown.itl(webadmin-0.js@101)
	at Unknown.BXp(webadmin-151.js@412)
	at Unknown.Ydv(webadmin-151.js@36)
	at Unknown.Ofv(webadmin-151.js@755108)
	at Unknown.Qjf(webadmin-151.js@107189)
	at Unknown.Gy(webadmin-0.js@102)
	at Unknown.wy(webadmin-0.js@59)
	at Unknown.$x(webadmin-0.js@19)
	at Unknown.Zx(webadmin-0.js@177)
	at Unknown.eval(webadmin-0.js@54)

_3p,org.ovirt.engine.ui.uicommonweb.models.hosts.network.DataFromHostSetupNetworksModel::$removeNetworkAttachmentFromParameters(Lorg/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel;
Lorg/ovirt/engine/core/common/businessentities/network/NetworkAttachment;)V,org.ovirt.engine.ui.uicommonweb.models.hosts.network.DataFromHostSetupNetworksModel,$removeNetworkAttachmentFromParameters,org/ovirt/engi
ne/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java,78,151


s4p,org.ovirt.engine.ui.uicommonweb.models.hosts.network.LogicalNetworkModelParametersHelper::$updateParametersToDetach(Lorg/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModelParametersHelper;)V,
org.ovirt.engine.ui.uicommonweb.models.hosts.network.LogicalNetworkModelParametersHelper,$updateParametersToDetach,org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModelParametersHelper.java,94,1
51

S6p,org.ovirt.engine.ui.uicommonweb.models.hosts.network.NetworkOperation$2$1::executeNetworkCommand(Lorg/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkItemModel;Lorg/ovirt/engine/ui/uicommonweb/models/h
osts/network/NetworkItemModel;Lorg/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel;[Ljava/lang/Object;)V,org.ovirt.engine.ui.uicommonweb.models.hosts.network.NetworkOperation$2$1,ex
ecuteNetworkCommand,org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java,84,151


A5p,org.ovirt.engine.ui.uicommonweb.models.hosts.network.NetworkOperationCommandTarget::$executeCommand(Lorg/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationCommandTarget;Lorg/ovirt/engine/ui/uico
mmonweb/UICommand;[Ljava/lang/Object;)V,org.ovirt.engine.ui.uicommonweb.models.hosts.network.NetworkOperationCommandTarget,$executeCommand,org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationComma
ndTarget.java,17,151


Version-Release number of selected component (if applicable):
4.0.2-0.1.rc.el7ev

How reproducible:
100

Steps to Reproduce:
1. Create bond and attach network to him via setup networks
2. Remove the network from DC while it is still attached to bond
3. Try to break the bond while the unmanaged network still attached to him

Actual results:
Ui exception when trying to break the bond - on 4.0.2


Expected results + Additional INFO:
On 3.6.8, when trying to break a bond that have an unmanaged network attached to him, it seems like we succeeding, network changes are  seems to be saved, but nothing actually happening and the bond still exist and the unmanaged network attached to him.  

So we need to decide:
1) To block breaking bond that have an unmanaged network attached to him, until removing the unmanaged network from him.
2) To allow it and the operation will be successful, the bond will break and the network will be removed.

Comment 1 Yaniv Kaul 2016-07-28 07:14:22 UTC

Can you install the debuginfo and get a cleaner stack?

Comment 2 Michael Burman 2016-07-28 08:30:47 UTC

Hi Yaniv,

The ovirt-engine-webadmin-portal-debuginfo installed by default, so i'm not sure i understand your request. 
Please let me know how i can provide a cleaner stack. Thanks

Comment 3 Yaniv Kaul 2016-07-28 08:55:57 UTC

(In reply to Michael Burman from comment #2)
> Hi Yaniv,
> 
> The ovirt-engine-webadmin-portal-debuginfo installed by default, so i'm not
> sure i understand your request. 
> Please let me know how i can provide a cleaner stack. Thanks

Oved - any idea why we have a ciphered stack, if the debuginfo is installed?

Comment 4 Oved Ourfali 2016-07-28 09:04:10 UTC

Alexander?

Comment 5 Alexander Wels 2016-07-28 12:16:31 UTC

Actually looks like Michael pasted the console from the browser and the UI.log. The problem appears to be in:


_3p,org.ovirt.engine.ui.uicommonweb.models.hosts.network.DataFromHostSetupNetworksModel::$removeNetworkAttachmentFromParameters(Lorg/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel;
Lorg/ovirt/engine/core/common/businessentities/network/NetworkAttachment;)V,org.ovirt.engine.ui.uicommonweb.models.hosts.network.DataFromHostSetupNetworksModel,$removeNetworkAttachmentFromParameters,org/ovirt/engi
ne/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java,78,151

Taking a quick look at the code it appears that either the networkAttachments field in the object is null or networkAttachment parameter is null. Since networkAttachments is initialized in the constructor, I am going with networkAttachment is null. But I don't have any setup in which I can create a bond to debug further.

Comment 6 Oved Ourfali 2016-07-28 12:24:03 UTC

I think the info should be enough for someone from network team to take a look.

Thanks Alexander.

Comment 7 Michael Burman 2016-07-28 12:53:49 UTC

Hi guys,

Thanks for looking into it,please ping me if you need a setup with this report.Thanks

Comment 8 Michael Burman 2016-12-06 08:25:28 UTC

Verified on - 4.1.0-0.2.master.20161205231208.gitf0af92b.el7.centos

Dan, will this be fixed for 4.0.z as well?

Comment 9 Dan Kenigsberg 2016-12-06 08:48:59 UTC

No, I don't think it's a recent regression, and do not see the urgency to push it to 4.0.z.