Created attachment 1184656 [details]
engine log

Description of problem:

When upgrading a cluster from 3.5 to 3.6 restoring a snapshot with saved ram which was created on 3.5 should be blocked.
In practice when doing the upgrade within 3.6 (I mean upgrading only cluster compatibility from 3.5 to 3.6 in a rhevm-3.6 env), this restoration isn't blocked and the vm is restored as 3.5 vm (features of 3.6 will be broken for that vm until hard boo (poweroff + start) )


Version-Release number of selected component (if applicable):
rhevm-3.6.8.1-0.1.el6.noarch
hosts were upgraded from vdsm-4.16.38-1.el7ev.x86_64 to vdsm-4.17.33-1.el7ev.noarch

How reproducible:
Seen this twice (flow is not a very common one).

Steps to Reproduce:
1. Have rhevm 3.6 with 3.5 DC/Cluster and host with vdsm 4.16.x
2. Create a vm in the cluster and start it.
3. Create a live snapshot with memory for the running vm.
4. Upgrade the cluster (put host to maintenance and upgrade vdsm)
6. Attempt to restore the snapshot after the upgrade is done.

Actual results:
Vm is restored and starts as a 3.5 vm (some 3.6 features will be brokem e.g. memory hotplug).

Expected results:
Vm is blocked with the proper error/warning message

Additional info:
in attached log, the vm's name is 'vm-live-snapshot'