RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1360789 - Make sure concat_subtype_id() does not invoke undefined behaviour
Summary: Make sure concat_subtype_id() does not invoke undefined behaviour
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: nftables
Version: 7.3
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Phil Sutter
QA Contact: Karel Volný
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-27 13:34 UTC by Phil Sutter
Modified: 2017-08-01 18:56 UTC (History)
6 users (show)

Fixed In Version: nftables-0.6-4.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-01 18:56:07 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:2047 0 normal SHIPPED_LIVE nftables bug fix and enhancement update 2017-08-01 18:13:06 UTC

Description Phil Sutter 2016-07-27 13:34:52 UTC
As reported by covscan:

expr_evaluate_concat() calls concat_subtype_lookup(type, --off), the signed 'off' might become negative as far as I can tell. The latter function in turn calls concat_subtype_id(type, n) where 'n' is '--off' converted to unsigned. In concat_subtype_id(), 'n' is used in the following expression:

return (type >> TYPE_BITS * n) & TYPE_MASK;

So 'TYPE_BITS * n' might exceed the number of bits in 'type' and therefore lead to undefined behaviour.

Comment 1 Phil Sutter 2016-09-08 13:33:35 UTC
This is the upstream fix to backport:

commit 83e52f7a7f5eaa893e146d23ff2e9292179f9485
Author: Phil Sutter <phil>
Date:   Tue Aug 30 19:39:52 2016 +0200

    evaluate: Avoid undefined behaviour in concat_subtype_id()
    
    For the left side of a concat expression, dtype is NULL and therefore
    off is 0. In that case the code expects to get a datatype of
    TYPE_INVALID, but this is fragile as the output of concat_subtype_id()
    is undefined for n > 32 / TYPE_BITS.
    
    To fix this, call datatype_lookup() directly passing the expected
    TYPE_INVALID as argument if off is 0.
    
    Signed-off-by: Phil Sutter <phil>
    Signed-off-by: Pablo Neira Ayuso <pablo>

Comment 7 errata-xmlrpc 2017-08-01 18:56:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2047


Note You need to log in before you can comment on or make changes to this bug.