RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1360892 - [extras-rhel-7.3.3] docker plugins services not restart after package upgrade
Summary: [extras-rhel-7.3.3] docker plugins services not restart after package upgrade
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: docker
Version: 7.2
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Lokesh Mandvekar
QA Contact: atomic-bugs@redhat.com
Yoana Ruseva
URL:
Whiteboard:
Depends On:
Blocks: 1428388 1441812
TreeView+ depends on / blocked
 
Reported: 2016-07-27 17:54 UTC by Qian Cai
Modified: 2019-03-06 02:45 UTC (History)
6 users (show)

Fixed In Version: docker-1.12.6-11.el7_3
Doc Type: Known Issue
Doc Text:
rhel-push-plugin service does not restart after package upgrade The docker service requires *rhel-push-plugin* to be started before itself. However, after upgrading the _docker_ and _docker-rhel-push-plugin_ packages, the docker daemon restarts while using the already existing *rhel-push-plugin* service in memory without restarting it. To work around this issue, manually restart *rhel-push-plugin* first, and the *docker* service afterwards.
Clone Of:
: 1365217 1428388 1441812 (view as bug list)
Environment:
Last Closed: 2017-03-02 19:09:13 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
This patch adds systemd post/postun/ fixes. (1.42 KB, patch)
2017-01-26 15:41 UTC, Daniel Walsh 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0406 0 normal SHIPPED_LIVE docker bug fix and enhancement update 2017-03-03 00:06:50 UTC

Description Qian Cai 2016-07-27 17:54:05 UTC 
Description of problem:
It came to my attention that rhel-push-plugin service does not restart after package upgrade. It still use the old version in memory, and I have to restart the service myself. I looked at the spec file and it seems only docker service will be restarted in postinstall section.

If so, maybe it also worth auditing docker-lvm-plugin.service and docker-novolume-plugin.service to see if they need to fix as well.

Version-Release number of selected component (if applicable):
docker-1.10.3-46.el7.9.x86_64

How reproducible:
always
Comment 2 Lokesh Mandvekar 2016-08-08 16:00:12 UTC 
I think we should let the users restart the plugins and not do this automatically.

Reason being for example, if a user chooses to install docker-latest when docker is already running, rhel-push-plugin will get restarted even though docker is using it.

I'm not sure yet how much of an effect the restart would have on already running docker, but I suspect such a thing being undesirable.

Thoughts?
Comment 3 Qian Cai 2016-08-08 16:08:42 UTC 
Maybe it will check if the upgraded docker or docker-latest is running and need a restart, if so restart all plugins, rhel-push-plugin, lvm, novolume etc.

If we upgraded either a docker or docker-latest packge that is not running, no need to restart all the plugins.
Comment 4 Lokesh Mandvekar 2016-08-08 16:12:58 UTC 
(In reply to CAI Qian from comment #3)
> Maybe it will check if the upgraded docker or docker-latest is running and
> need a restart, if so restart all plugins, rhel-push-plugin, lvm, novolume
> etc.
> 
> If we upgraded either a docker or docker-latest packge that is not running,
> no need to restart all the plugins.

Think you got a point, let me include the fix in the new docker-latest, and we can check it out.
Comment 6 Daniel Walsh 2016-08-19 21:12:43 UTC 
Can we move this to the modified state?
Comment 7 Yoana Ruseva 2016-09-28 13:36:01 UTC 
Is it fixed for 7.3 so I can remove it from the Known Issues?
Comment 8 Lokesh Mandvekar 2016-09-28 13:40:07 UTC 
Dan, Yoana, I haven't yet included the fix for these in 7.3.0. I'll fix them in 7.3.1
Comment 9 Daniel Walsh 2016-10-18 15:02:41 UTC 
Fixed in docker-1.12
Comment 14 Qian Cai 2017-01-26 14:41:52 UTC 
What's the status of this BZ?
Comment 15 Daniel Walsh 2017-01-26 15:41:30 UTC 
Created attachment 1244801 [details]
This patch adds systemd post/postun/ fixes.

Lokesh can you add this patch to the spec file.
Comment 20 Daniel Walsh 2017-02-22 14:59:00 UTC 
Lokesh can you add these restarts?
Comment 28 Qian Cai 2017-02-27 21:18:31 UTC 
This is still broken. I upgraded the docker today but the plugin seems never get restarted (start time is still Feb23).

# ps aux | grep plugin
root     17805  0.0  0.0 355156  6532 ?        Ssl  Feb23   0:01 /usr/libexec/docker/rhel-push-plugin
root     31606  0.0  0.3 538192 24356 ?        Ssl  16:08   0:00 /usr/bin/dockerd-current --add-runtime docker-runc=/usr/libexec/docker/docker-runc-current --default-runtime=docker-runc --authorization-plugin=rhel-push-plugin --exec-opt native.cgroupdriver=systemd --userland-proxy-path=/usr/libexec/docker/docker-proxy-current --selinux-enabled --log-driver=journald --storage-driver overlay2 --add-registry registry.access.redhat.com

docker-1.12.6-11.el7.x86_64
Comment 30 errata-xmlrpc 2017-03-02 19:09:13 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0406.html
Note You need to log in before you can comment on or make changes to this bug.