Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
When using the -C option for fixfiles, the verify and check commands (which are supposed to not change any filesystem labels) actually *do* modify labels.
Version-Release number of selected component (if applicable):
policycoreutils-2.5-5.1.el7.x86_64
How reproducible:
somewhat easily
Steps to Reproduce:
1. Make a fake version of /etc/selinux/targeted/contexts/files/file_contexts with rules for /etc removed, so that when you pass it to fixfiles -C it will try to relabel /etc:
cp /etc/selinux/targeted/contexts/files/file_contexts file_contexts_dummy
sed -i -e '/^\/etc/d' file_contexts_dummy
2. Make a mislabelled file in /etc:
touch /etc/relabelthis
chcon -t admin_home_t /etc/relabelthis
3. Run: fixfiles -C file_contexts_dummy check
or: fixfiles -C file_contexts_dummy verify
Actual results:
Prints:
/sbin/restorecon reset /etc/relabelthis context unconfined_u:object_r:admin_home_t:s0->unconfined_u:object_r:etc_t:s0
and then file context is actually changed:
-rw-r--r--. root root unconfined_u:object_r:etc_t:s0 /etc/relabelthis
Expected results:
Should print but not change file context.
Additional info:
Seems to be because -n is not being passed down to restorecon properly in the code path for -C. This patch fixes it:
--- /usr/sbin/fixfiles 2016-07-14 03:58:07.000000000 -0400
+++ fixfiles.patched 2016-07-28 01:08:23.776210742 -0400
@@ -194,7 +194,7 @@
esac; \
fi; \
done | \
- ${RESTORECON} ${VERBOSE} -i -f - -R `exclude_dirs`; \
+ ${RESTORECON} $* ${VERBOSE} -i -f - -R `exclude_dirs`; \
rm -f ${TEMPFILE} ${PREFCTEMPFILE}
fi
}
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://rhn.redhat.com/errata/RHEA-2016-2279.html
Description of problem: When using the -C option for fixfiles, the verify and check commands (which are supposed to not change any filesystem labels) actually *do* modify labels. Version-Release number of selected component (if applicable): policycoreutils-2.5-5.1.el7.x86_64 How reproducible: somewhat easily Steps to Reproduce: 1. Make a fake version of /etc/selinux/targeted/contexts/files/file_contexts with rules for /etc removed, so that when you pass it to fixfiles -C it will try to relabel /etc: cp /etc/selinux/targeted/contexts/files/file_contexts file_contexts_dummy sed -i -e '/^\/etc/d' file_contexts_dummy 2. Make a mislabelled file in /etc: touch /etc/relabelthis chcon -t admin_home_t /etc/relabelthis 3. Run: fixfiles -C file_contexts_dummy check or: fixfiles -C file_contexts_dummy verify Actual results: Prints: /sbin/restorecon reset /etc/relabelthis context unconfined_u:object_r:admin_home_t:s0->unconfined_u:object_r:etc_t:s0 and then file context is actually changed: -rw-r--r--. root root unconfined_u:object_r:etc_t:s0 /etc/relabelthis Expected results: Should print but not change file context. Additional info: Seems to be because -n is not being passed down to restorecon properly in the code path for -C. This patch fixes it: --- /usr/sbin/fixfiles 2016-07-14 03:58:07.000000000 -0400 +++ fixfiles.patched 2016-07-28 01:08:23.776210742 -0400 @@ -194,7 +194,7 @@ esac; \ fi; \ done | \ - ${RESTORECON} ${VERBOSE} -i -f - -R `exclude_dirs`; \ + ${RESTORECON} $* ${VERBOSE} -i -f - -R `exclude_dirs`; \ rm -f ${TEMPFILE} ${PREFCTEMPFILE} fi }