Bug 1361409 - Review Request: python-pytest-xdist - py.test xdist plugin for distributed testing and loop-on-failing modes
Summary: Review Request: python-pytest-xdist - py.test xdist plugin for distributed te...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-29 03:55 UTC by Scott Talbert
Modified: 2016-08-27 10:38 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-22 16:52:43 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Scott Talbert 2016-07-29 03:55:48 UTC
Spec URL: https://www.techie.net/~talbert/python-pytest-xdist.spec
SRPM URL: https://www.techie.net/~talbert/python-pytest-xdist-1.14-1.fc24.src.rpm
Description: The pytest-xdist plugin extends py.test with some unique test execution modes:
* test run parallelization: if you have multiple CPUs or hosts you can use
  those for a combined test run. This allows to speed up development or to use
  special resources of remote machines.
* --boxed: (not available on Windows) run each test in a boxed subprocess to
  survive SEGFAULTS or otherwise dying processes
* --looponfail: run your tests repeatedly in a subprocess. After each run
  py.test waits until a file in your project changes and then re-runs the
  previously failing tests. This is repeated until all tests pass after which
  again a full run is performed.
* Multi-Platform coverage: you can specify different Python interpreters or
  different platforms and run tests in parallel on all of them.
Fedora Account System Username: swt2c

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-08-11 02:03:51 UTC
I think you can remove the references to missing functionality on Windows ;)
You should also wrap %description to 80 columns.

.egg-info doesn't have to be removed.

In Summary: I'd say change "py.test xdist plugin" to "py.test plugin" for better flow.

+ package name is OK
+ license is accpetable (MIT)
+ license is specified correctly
+ modern python packaging template is used
+ %python_provide is used
+ no scriptlets present or necessary
+ P/R/BR look OK
+ builds and install OK
+ latest version
+ rpmlint and fedora-review have nothing useful to say

Package is APPROVED.

Thanks for packaging this, I wanted to use this a few times :)

Comment 2 Scott Talbert 2016-08-11 02:58:40 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> I think you can remove the references to missing functionality on Windows ;)
> You should also wrap %description to 80 columns.
> 
> .egg-info doesn't have to be removed.
> 
> In Summary: I'd say change "py.test xdist plugin" to "py.test plugin" for
> better flow.
> 

Thanks for the review on this and timeout.  :)  Good comments - I'll fix up those issues upon import to dist-git.

Comment 3 Gwyn Ciesla 2016-08-11 15:30:17 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-xdist

Comment 4 Fedora Update System 2016-08-12 04:03:23 UTC
python-pytest-xdist-1.14-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ea1cac7466

Comment 5 Fedora Update System 2016-08-12 04:04:02 UTC
python-pytest-xdist-1.14-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe4490b1c4

Comment 6 Fedora Update System 2016-08-12 04:04:57 UTC
python-pytest-xdist-1.14-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-22d98f1c22

Comment 7 Fedora Update System 2016-08-12 14:27:39 UTC
python-pytest-xdist-1.14-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ea1cac7466

Comment 8 Fedora Update System 2016-08-12 20:52:27 UTC
python-pytest-xdist-1.14-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-22d98f1c22

Comment 9 Fedora Update System 2016-08-12 20:52:30 UTC
python-pytest-xdist-1.14-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe4490b1c4

Comment 10 Fedora Update System 2016-08-22 16:52:40 UTC
python-pytest-xdist-1.14-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2016-08-27 10:38:32 UTC
python-pytest-xdist-1.14-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.