Hide Forgot
Description of problem: I just tried to compile package dvgrab-1.6-1 from package Redhat Fedora Core 3 Test 3. The compiler said smiltime.cc(349): warning #1011: missing return statement at end of non-void function "SMIL::Time::serialise" The source code is string Time::serialise() { toString(); } Might be worthwhile putting in a return statement at the end of the function. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Unless this is an actual software defect that causes bad behavior or crashes, is it inappropriate to complain about compiler warnings here. Please make sure this is fixed at the upstream dvgrab project.
>Unless this is an actual software defect that causes bad behavior Returning stack rubbish to the caller is one of the oldest C++ mistakes in the book. I'm surprised the C++ compiler accepts this code. It is a certain software defect every time this code is executed.