Bug 1361551 - Vdsm logging should be improved
Summary: Vdsm logging should be improved
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: vdsm
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-3.6.9
: ---
Assignee: Milan Zamazal
QA Contact: Shira Maximov
URL:
Whiteboard:
Depends On: 1351247
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-29 12:05 UTC by Sandro Bonazzola
Modified: 2016-09-21 18:07 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1351247
Environment:
Last Closed: 2016-09-21 18:07:21 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1925 0 normal SHIPPED_LIVE vdsm 3.6.9 bug fix and enhancement update 2016-09-21 21:58:32 UTC
oVirt gerrit 59999 0 None MERGED rpc: Log also error codes of RPC calls 2020-06-25 19:10:16 UTC
oVirt gerrit 60096 0 None MERGED xmlrpc: Hide fenceNode password in the log 2020-06-25 19:10:16 UTC
oVirt gerrit 60097 0 None MERGED rpc: Lower logging priority just for getAllVmStats 2020-06-25 19:10:15 UTC
oVirt gerrit 60098 0 None MERGED rpc: Log calls of API methods with possibly large results 2020-06-25 19:10:15 UTC
oVirt gerrit 60099 0 None MERGED rpc: Use Suppressed class instead of logging workarounds 2020-06-25 19:10:14 UTC
oVirt gerrit 60100 0 None MERGED logging: Introduce throttledlog 2020-06-25 19:10:14 UTC
oVirt gerrit 60101 0 None MERGED rpc: Log important info from VM stats 2020-06-25 19:10:14 UTC
oVirt gerrit 60102 0 None MERGED rpc: Log RPC call summary on info level 2020-06-25 19:10:14 UTC
oVirt gerrit 60103 0 None MERGED rpc: Log also error codes of RPC calls 2020-06-25 19:10:13 UTC

Comment 1 Michal Skrivanek 2016-07-29 13:12:06 UTC
logging improved

Comment 2 Shira Maximov 2016-08-30 12:53:13 UTC
verified on : 
Red Hat Enterprise Virtualization Manager Version: 3.6.9-0.1.el6


verification steps:
1. check that there are INFO messages of "Current getAllVmStats.." which contains correct information: 

root@RHEL7 ~]# cat /var/log/vdsm/vdsm.log | grep "Current getAllVmStats"
jsonrpc.Executor/2::INFO::2016-08-30 14:54:33,391::throttledlog::105::throttled::(log) Current getAllVmStats: {u'508c2649-a02f-46d2-a2e1-b87e77fb6155': 'Up', u'0ef0a731-c2a9-47fb-8c90-ac946d2cef38': 'Up', u'fa667c4a-c897-4605-9630-2f892d3dc92d': 'Up'}
jsonrpc.Executor/6::INFO::2016-08-30 15:07:11,851::throttledlog::105::throttled::(log) Current getAllVmStats: {u'508c2649-a02f-46d2-a2e1-b87e77fb6155': 'Up', u'0ef0a731-c2a9-47fb-8c90-ac946d2cef38': 'Up'}
jsonrpc.Executor/1::INFO::2016-08-30 15:19:48,869::throttledlog::105::throttled::(log) Current getAllVmStats: {u'508c2649-a02f-46d2-a2e1-b87e77fb6155': 'Up', u'0ef0a731-c2a9-47fb-8c90-ac946d2cef38': 'Up'}



2. check that art INFO messages of RPC call XXX succeeded/failed in YYY seconds" message which contains correct information: 

 [root@RHEL7 ~]# cat /var/log/vdsm/vdsm.log | grep "RPC call"
Thread-818::INFO::2016-08-30 14:54:02,771::bindingxmlrpc::1308::vds::(wrapper) RPC call getAllVmStats finished (code=0) in 0.01 seconds
Thread-819::INFO::2016-08-30 14:54:02,803::bindingxmlrpc::1308::vds::(wrapper) RPC call vmGetIoTunePolicy finished (code=0) in 0.00 seconds
jsonrpc.Executor/5::INFO::2016-08-30 14:54:03,174::__init__::514::jsonrpc.JsonRpcServer::(_serveRequest) RPC call Host.getAllVmStats succeeded in 0.01 seconds
Thread-820::INFO::2016-08-30 14:54:03,722::bindingxmlrpc::1308::vds::(wrapper) RPC call vmGetIoTunePolicy finished (code=0) in 0.00 seconds
Thread-821::INFO::2016-08-30 14:54:04,483::bindingxmlrpc::1308::vds::(wrapper) RPC call vmGetIoTunePolicy finished (code=0) in 0.00 seconds
jsonrpc.Executor/6::INFO::2016-08-30 14:54:10,281::__init__::514::jsonrpc.JsonRpcServer::(_serveRequest) RPC call Host.getStats succeeded in 0.02 seconds
Thread-823::INFO::2016-08-30 14:54:17,817::bindingxmlrpc::1308::vds::(wrapper) RPC call getAllVmStats finished (code=0) in 0.00 seconds
Thread-824::INFO::2016-08-30 14:54:17,849::bindingxmlrpc::1308::vds::(wrapper) RPC call vmGetIoTunePolicy finished (code=0) in 0.00 seconds
jsonrpc.Executor/0::INFO::2016-08-30 14:54:18,289::__init__::514::jsonrpc.JsonRpcServer::(_serveRequest) RPC call Host.getAllVmStats succeeded in 0.00 seconds

Comment 4 errata-xmlrpc 2016-09-21 18:07:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1925.html


Note You need to log in before you can comment on or make changes to this bug.