Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-windtalker.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-windtalker-0.0.4-1.fc25.src.rpm Description: Super easy-to-use encryption and decryption tool Fedora Account System Username: williamjmorenor Scrath Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15086675
Looks like Fedora review wants a -doc subpackage and not a -docs subpackage. New build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15087346 Epel7 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15087336
+ sphinx-build -b html -d build/doctrees source build/html Making output directory... Running Sphinx v1.2.3 loading pickled environment... not yet created RSA算法原理介绍.rst:: ERROR: non-ASCII filename not supported on this filesystem encoding 'ANSI_X3.4-1968', skipped. Theme error: no theme named 'alabaster' found (missing theme.conf?) RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.mXnQrE (%install) Bad exit status from /var/tmp/rpm-tmp.mXnQrE (%install) Child return code was: 1 EXCEPTION: [Error()] Traceback (most recent call last): File "/usr/lib/python3.5/site-packages/mockbuild/trace_decorator.py", line 88, in trace result = func(*args, **kw) File "/usr/lib/python3.5/site-packages/mockbuild/util.py", line 551, in do raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode) mockbuild.exception.Error: Command failed. See logs for output. # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/python-windtalker.spec Mock Version: 1.2.18
The build work for epel7, f24 and f25, but fail in f22 and f23. In Fedora 22 the %{python3_pkgversion} is not defined, but it is EOL so there is no deal. DEBUG util.py:421: Error: No Package found for python%{python3_pkgversion}-cryptography DEBUG util.py:421: Error: No Package found for python%{python3_pkgversion}-devel DEBUG util.py:421: Error: No Package found for python%{python3_pkgversion}-rsa Looks like a missing requires for the alabaster theme of sphinx, but not sure how to deal with the encoding issue, so I think I will skip the build of docs in fedora<24
Omar con you try LANG=en_US.UTF-8 fedora-review -n 1361891 or LANG=en_US.UTF-8 fedora-review -n 1361891 Please
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-windtalker.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-windtalker-0.0.4-2.fc26.src.rpm Scratch builds: f26: http://koji.fedoraproject.org/koji/taskinfo?taskID=15110151 f25: http://koji.fedoraproject.org/koji/taskinfo?taskID=15110165 f24: http://koji.fedoraproject.org/koji/taskinfo?taskID=15110174 f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=15110194 el7: http://koji.fedoraproject.org/koji/taskinfo?taskID=15110148 Secondary Arch builds: s390: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2306155 arm: http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3654120 http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3578008 %changelog * Tue Aug 02 2016 William Moreno <williamjmorenor> - 0.0.4-2 - Disable doc build. Should build fine now, will enable doc builds only in Fedora>24
Reviewer ping ;)
reviewer Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck in /home/lkf/rpmrevisor/1361891-python- windtalker/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [X]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site- packages, /usr/lib/python3.4 [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [X]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [X]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [X]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-windtalker , python3-windtalker [X]: Package functions as described. [x]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [X]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Omar do you need I fix something is this packaging?
Package look fine. Approved.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-windtalker
python-windtalker-0.0.4-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-019a7d20a4
python-windtalker-0.0.4-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-019a7d20a4
python-windtalker-0.0.4-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.