Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
aarch64 use kernel-4.5.0-0.48.el7.aarch64, it doesn't have XFS GETNEXTQUOTA feature. But xfsprogs-4.5.0-5.el7.aarch64(from RHEL-7.3 Alhpa-1.0) merged this feature.
This feature add a new flag GETNEXTQUOTA_FLAG. So if xfsprogs merged this feature, it can't work well with kernel not merge it, then return "XFS_GETQUOTA: Invalid argument", due to kernel don't know this new flag.
Version-Release number of selected component (if applicable):
kernel-4.5.0-0.48.el7.aarch64
xfsprogs-4.5.0-5.el7.aarch64
How reproducible:
xfstests xfs/299 or xfs/260(but this case can reproduce another bug, I don't know if aarch64 kernel want to merge that)
Actual results:
XFS_GETQUOTA: Invalid argument
Expected results:
No error maybe?
Additional info:
In xfsprogs quota/report.c report_user_mount():
....
} else if (report_mount(fp, id, NULL, &oid, form,
XFS_USER_QUOTA, mount,
flags|GETNEXTQUOTA_FLAG)) {
id = oid + 1;
flags |= GETNEXTQUOTA_FLAG;
flags |= NO_HEADER_FLAG;
while (report_mount(fp, id, NULL, &oid, form, XFS_USER_QUOTA,
mount, flags)) {
id = oid + 1;
}
} else {
....
....
It try to run GETNEXTQUOTA ioctl(this bug happened at here), if it return failure, then back to the old GETQUOTA ioctl.
1. Should aarch64 kernel merge GETNEXTQUOTA feature?
2. Or xfsprogs find a way to filter this error output, likes below(haven't tested):
diff --git a/quota/report.c b/quota/report.c
index 59290e1..964df33 100644
--- a/quota/report.c
+++ b/quota/report.c
@@ -348,7 +348,8 @@ report_mount(
cmd = XFS_GETQUOTA;
if (xfsquotactl(cmd, dev, type, id, (void *)&d) < 0) {
- if (errno != ENOENT && errno != ENOSYS && errno != ESRCH)
+ if (errno != ENOENT && errno != ENOSYS \
+ && errno != ESRCH && errno != EINVAL)
perror("XFS_GETQUOTA");
return 0;
}
What do you think, Eric?
Anyway, I think we shouldn't let customers face this un-compatible problem.
Eric suggest to fix this bug in xfsprogs, I have sent a patch to upstream(Thanks Eric's help): [PATCH] xfs_quota: fall back silently if XFS_GETNEXTQUOTA fails
So it's not an aarch64 bug now, change component to xfsprogs.
Description of problem: aarch64 use kernel-4.5.0-0.48.el7.aarch64, it doesn't have XFS GETNEXTQUOTA feature. But xfsprogs-4.5.0-5.el7.aarch64(from RHEL-7.3 Alhpa-1.0) merged this feature. This feature add a new flag GETNEXTQUOTA_FLAG. So if xfsprogs merged this feature, it can't work well with kernel not merge it, then return "XFS_GETQUOTA: Invalid argument", due to kernel don't know this new flag. Version-Release number of selected component (if applicable): kernel-4.5.0-0.48.el7.aarch64 xfsprogs-4.5.0-5.el7.aarch64 How reproducible: xfstests xfs/299 or xfs/260(but this case can reproduce another bug, I don't know if aarch64 kernel want to merge that) Actual results: XFS_GETQUOTA: Invalid argument Expected results: No error maybe? Additional info: In xfsprogs quota/report.c report_user_mount(): .... } else if (report_mount(fp, id, NULL, &oid, form, XFS_USER_QUOTA, mount, flags|GETNEXTQUOTA_FLAG)) { id = oid + 1; flags |= GETNEXTQUOTA_FLAG; flags |= NO_HEADER_FLAG; while (report_mount(fp, id, NULL, &oid, form, XFS_USER_QUOTA, mount, flags)) { id = oid + 1; } } else { .... .... It try to run GETNEXTQUOTA ioctl(this bug happened at here), if it return failure, then back to the old GETQUOTA ioctl. 1. Should aarch64 kernel merge GETNEXTQUOTA feature? 2. Or xfsprogs find a way to filter this error output, likes below(haven't tested): diff --git a/quota/report.c b/quota/report.c index 59290e1..964df33 100644 --- a/quota/report.c +++ b/quota/report.c @@ -348,7 +348,8 @@ report_mount( cmd = XFS_GETQUOTA; if (xfsquotactl(cmd, dev, type, id, (void *)&d) < 0) { - if (errno != ENOENT && errno != ENOSYS && errno != ESRCH) + if (errno != ENOENT && errno != ENOSYS \ + && errno != ESRCH && errno != EINVAL) perror("XFS_GETQUOTA"); return 0; } What do you think, Eric? Anyway, I think we shouldn't let customers face this un-compatible problem.