Bug 136268 - Add extras packages the BRs
Add extras packages the BRs
Product: Fedora
Classification: Fedora
Component: gstreamer-plugins-good (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Adam Jackson
: FutureFeature
: 229312 (view as bug list)
Depends On: Merge 239132
  Show dependency treegraph
Reported: 2004-10-18 20:28 EDT by David Mohring
Modified: 2009-09-21 15:51 EDT (History)
3 users (show)

See Also:
Fixed In Version: 0.10.5-6.fc7
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-18 13:33:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
gstreamer-plugins.spec (18.32 KB, text/plain)
2004-10-18 20:29 EDT, David Mohring
no flags Details
Diff of removed sources from libshout to libshoutogg (501 bytes, text/plain)
2004-10-18 20:32 EDT, David Mohring
no flags Details
libshoutogg tarball (217.84 KB, application/octet-stream)
2004-10-18 20:34 EDT, David Mohring
no flags Details
patch for gst-plugins-0.8.5/ext/shout2/gstshout2.c (2.40 KB, patch)
2004-10-18 20:36 EDT, David Mohring
no flags Details | Diff

  None (edit)
Description David Mohring 2004-10-18 20:28:35 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041016

Description of problem:
While Fedora's gstreamer is crippled by the lack of some codecs, It
would be better to support and promote any relatively unencumbered
codecs or protocols as much as possible. For example: streaming

The following attachments include the modifed spec file and extra
sources to static build and link a hacked version of Icecast's
libshout2 library,  
with ONLY OGG support built in, for Gstreamer's shout2send sink



gst-inspect shout2send

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
See the attachments. 

Additional info:

Note that gst-inspect-gui Sync>Network>shout2send 
still shows mp3 support, I forgot to remove it from the register. Will
fix tonight.
Comment 1 David Mohring 2004-10-18 20:29:40 EDT
Created attachment 105406 [details]
Comment 2 David Mohring 2004-10-18 20:32:48 EDT
Created attachment 105407 [details]
Diff of removed sources from libshout to libshoutogg
Comment 3 David Mohring 2004-10-18 20:34:07 EDT
Created attachment 105408 [details]
libshoutogg tarball
Comment 4 David Mohring 2004-10-18 20:36:51 EDT
Created attachment 105409 [details]
patch for gst-plugins-0.8.5/ext/shout2/gstshout2.c
Comment 5 Colin Walters 2004-10-20 16:16:33 EDT
Hi, the patches are appreciated, but this looks like something that should go
upstream, not here.  Can you file a bug on http://bugzilla.gnome.org, product
GStreamer, component gst-plugins?
Comment 6 David Mohring 2004-10-20 17:51:31 EDT
It's not an issue for the gstreamer developers. The added
functionality is to get around parts of the source code that
Redhat/FedoraCore removed due to concern of patents about MP3.

For example, with inclusion of libshout2ogg, following now works on
either the Freshrpms or FC3.

gst-launch alsasrc device=hw:1,0 ! vorbisenc bitrate=32000  !
shout2send ip=XXX.XXX.XXX.XXX port=8000 password=hackme mount=test1 
name="testing" protocol=3

It promotes the use of Vorbis OGG as a replacment for MP3.
Comment 7 Colin Walters 2004-10-21 13:48:19 EDT
I'm not sure I understand.  Isn't streaming Vorbis useful even if you have mp3
support?  The upstream GStreamer developers are the ones qualified to review and
integrate this code if they want, not me.  
Comment 8 John Thacker 2004-11-04 11:06:16 EST
Colin-- you misunderstand somewhat.  GStreamer already supports
streaming Vorbis.  Problem is that the same plugin supports both
streaming Vorbis and streaming mp3.  As a result, FC3 just doesn't
ship the plugin at all, because of mp3 patent concerns.  This patch
leaves in the Vorbis support, but removes the mp3 support.  As such,
the GStreamer guys are not going to want to integrate it upstream,
since it only removes functionality.

It's much better than not shipping the plugin at all for people who
don't add mp3 support.  Disadvantage:  People who _do_ want streaming
mp3 support would have to replace a plugin instead of just adding a
missing one, making the packaging more irritating.
Comment 9 Kyrre Ness Sjøbæk 2004-11-04 12:53:37 EST
Just out of curiosity: Is the transport protocoll patented? Or just
the codek?

Because: if the mp3 decoding part is missing - we won't break any
patents, right?

As far as i can see - nobody can say anything about shipping this
plugin. It is just a system for downloading mp3s and oggs, not playing
them? As far as i can see, the justification for not shipping it is
about as bad as if anybody mentioned not to ship http/ftp - as it MAY
be used to download patent-encumbered mp3's...
Comment 10 Colin Walters 2004-11-04 13:23:42 EST
John: Thanks for the explanation, I am just dense apparently :)
I'll have a look at getting the patch into FC4.
Comment 11 Colin Walters 2004-11-09 17:25:26 EST
Ok, I had a look at this.  We have the additional issue of course that we don't
package libshout2.  I'll have to have a look at packaging that first.
Comment 12 Rahul Sundaram 2004-11-14 04:43:41 EST
You should probably tell upstream to split up the plugins to support
mp3 and ogg vorbis independantly
Comment 13 Matt Domsch 2005-11-25 18:46:54 EST
Is the proper bug to request libshout be upgraded to libshout2 for FC5-devel? 
Or should that be a separate request?  ices2 will require libshout2.
Comment 14 Bastien Nocera 2007-02-01 09:40:15 EST
Note that libshout 2.2.x is in the Extras now.

If somebody fancies getting the single plugin (2 source files!) compiled in its
own package, I don't think anyone would mind very much.

Either that, or wait until libshout is in "Fedora" (not Core/Extras) and depend
on it then.
Comment 15 Adam Jackson 2007-04-04 12:43:12 EDT
*** Bug 229312 has been marked as a duplicate of this bug. ***
Comment 16 Bastien Nocera 2007-04-04 12:49:51 EDT
We need to add those to the BRs:
Comment 17 Matthias Clasen 2007-04-17 12:39:30 EDT
Moving off FC7Target
Comment 18 Bastien Nocera 2007-05-18 13:33:34 EDT
Matthias fixed this. Fixed in 0.10.5-6.fc7

Note You need to log in before you can comment on or make changes to this bug.