Red Hat Bugzilla – Bug 136268
Add extras packages the BRs
Last modified: 2009-09-21 15:51:40 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041016
Description of problem:
While Fedora's gstreamer is crippled by the lack of some codecs, It
would be better to support and promote any relatively unencumbered
codecs or protocols as much as possible. For example: streaming
The following attachments include the modifed spec file and extra
sources to static build and link a hacked version of Icecast's
with ONLY OGG support built in, for Gstreamer's shout2send sink
Version-Release number of selected component (if applicable):
Steps to Reproduce:
See the attachments.
Note that gst-inspect-gui Sync>Network>shout2send
still shows mp3 support, I forgot to remove it from the register. Will
Created attachment 105406 [details]
Created attachment 105407 [details]
Diff of removed sources from libshout to libshoutogg
Created attachment 105408 [details]
Created attachment 105409 [details]
patch for gst-plugins-0.8.5/ext/shout2/gstshout2.c
Hi, the patches are appreciated, but this looks like something that should go
upstream, not here. Can you file a bug on http://bugzilla.gnome.org, product
GStreamer, component gst-plugins?
It's not an issue for the gstreamer developers. The added
functionality is to get around parts of the source code that
Redhat/FedoraCore removed due to concern of patents about MP3.
For example, with inclusion of libshout2ogg, following now works on
either the Freshrpms or FC3.
gst-launch alsasrc device=hw:1,0 ! vorbisenc bitrate=32000 !
shout2send ip=XXX.XXX.XXX.XXX port=8000 password=hackme mount=test1
It promotes the use of Vorbis OGG as a replacment for MP3.
I'm not sure I understand. Isn't streaming Vorbis useful even if you have mp3
support? The upstream GStreamer developers are the ones qualified to review and
integrate this code if they want, not me.
Colin-- you misunderstand somewhat. GStreamer already supports
streaming Vorbis. Problem is that the same plugin supports both
streaming Vorbis and streaming mp3. As a result, FC3 just doesn't
ship the plugin at all, because of mp3 patent concerns. This patch
leaves in the Vorbis support, but removes the mp3 support. As such,
the GStreamer guys are not going to want to integrate it upstream,
since it only removes functionality.
It's much better than not shipping the plugin at all for people who
don't add mp3 support. Disadvantage: People who _do_ want streaming
mp3 support would have to replace a plugin instead of just adding a
missing one, making the packaging more irritating.
Just out of curiosity: Is the transport protocoll patented? Or just
Because: if the mp3 decoding part is missing - we won't break any
As far as i can see - nobody can say anything about shipping this
plugin. It is just a system for downloading mp3s and oggs, not playing
them? As far as i can see, the justification for not shipping it is
about as bad as if anybody mentioned not to ship http/ftp - as it MAY
be used to download patent-encumbered mp3's...
John: Thanks for the explanation, I am just dense apparently :)
I'll have a look at getting the patch into FC4.
Ok, I had a look at this. We have the additional issue of course that we don't
package libshout2. I'll have to have a look at packaging that first.
You should probably tell upstream to split up the plugins to support
mp3 and ogg vorbis independantly
Is the proper bug to request libshout be upgraded to libshout2 for FC5-devel?
Or should that be a separate request? ices2 will require libshout2.
Note that libshout 2.2.x is in the Extras now.
If somebody fancies getting the single plugin (2 source files!) compiled in its
own package, I don't think anyone would mind very much.
Either that, or wait until libshout is in "Fedora" (not Core/Extras) and depend
on it then.
*** Bug 229312 has been marked as a duplicate of this bug. ***
We need to add those to the BRs:
Moving off FC7Target
Matthias fixed this. Fixed in 0.10.5-6.fc7