RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1362762 - Script header is erased if author is missing in INI
Summary: Script header is erased if author is missing in INI
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: preupgrade-assistant
Version: 6.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Petr Hracek
QA Contact: Alois Mahdal
URL:
Whiteboard:
: 1361489 (view as bug list)
Depends On:
Blocks: 1335121
TreeView+ depends on / blocked
 
Reported: 2016-08-03 05:25 UTC by Alois Mahdal
Modified: 2016-11-04 08:58 UTC (History)
4 users (show)

Fixed In Version: preupgrade-assistant-2.1.9-5.el6
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-04 08:58:18 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2616 0 normal SHIPPED_LIVE preupgrade-assistant bug fix and enhancement update 2016-11-03 16:23:38 UTC

Description Alois Mahdal 2016-08-03 05:25:59 UTC 
Description of problem
======================

Script header is erased if author is missing in INI.

With INI like this:

    [preupgrade]
    check_script = check.sh
    content_title = test module donna
    solution = solution.txt
    content_description = This is described as test module donna

and check.sh (what preupg-content-generator generated):

    #!/bin/bash

    . /usr/share/preupgrade/common.sh

    #END GENERATED SECTION

    ### For more information see 'man preupg-content-creator' or 'man preupgrade-assistant-api'.

    exit_pass

before running preupg-xccdf-compose, the build results in check.sh like
this (example prefixed by `|` to show empty lines):

    |
    |
    |
    |
    |exit_pass

that is, four empty lines plus the code inserted by user.


Version-Release number of selected component
============================================

preupgrade-assistant-2.1.8-2.el6


How reproducible
================

Always


Steps to Reproduce
==================

 1. Run preupg-content-creator; fill in anything; leave defaults where possible
 2. run preupg-xccdf-compose


Actual results
==============

check.sh is empty and unusable.  running the module would result in error


Expected results
================

A working module with replaced header


Additional info
===============

Notice that aside from the fact that the check.sh is unusable, also
preupg-xccdf-compose is apparently ignoring the `#END GENERATED SECTION`
delimiter.
Comment 1 Petr Stodulka 2016-08-03 07:37:19 UTC 
Petr fixed that already in upstream. See commit ec09e450.
Comment 3 Alois Mahdal 2016-08-03 14:55:41 UTC 
(In reply to pstodulk from comment #1)
> Petr fixed that already in upstream. See commit ec09e450.

Wow, I *knew* I saw it somewhere but couldn't remember where... :)

Good to know the fix is on its way...
Comment 4 Petr Hracek 2016-08-17 11:59:40 UTC 
This is already fixed by upstream commit https://github.com/upgrades-migrations/preupgrade-assistant/commit/ec09e45032a9d6ed2b4873dafe425f30b96b2f47
Comment 6 Alois Mahdal 2016-09-16 03:11:43 UTC 
Using last build: preupgrade-assistant-2.1.9-8.el6

Many tests now use mock modules auto-generated using this approach.  I have removed the author from some; and the generated modules work fine.
Comment 7 Petr Hracek 2016-10-18 13:24:00 UTC 
*** Bug 1361489 has been marked as a duplicate of this bug. ***
Comment 9 errata-xmlrpc 2016-11-04 08:58:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2616.html
Note You need to log in before you can comment on or make changes to this bug.