Spec URL: https://carlgeorge.fedorapeople.org/perl-LWP-UserAgent-DNS-Hosts/perl-LWP-UserAgent-DNS-Hosts.spec SRPM URL: https://carlgeorge.fedorapeople.org/perl-LWP-UserAgent-DNS-Hosts/perl-LWP-UserAgent-DNS-Hosts-0.08-1.fc26.src.rpm Description: LWP::UserAgent::DNS::Hosts is a module to override HTTP/HTTPS request peer addresses that uses LWP::UserAgent. This module concept was got from LWP::Protocol::PSGI. Fedora Account System Username: carlgeorge
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-LWP-UserAgent-DNS-Hosts-0.08-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.8.1 1 perl(Carp) 1 perl(LWP::Protocol) 1 perl(LWP::Protocol::http) 1 perl(LWP::Protocol::https) 1 perl(LWP::UserAgent::DNS::Hosts) 1 perl(Scope::Guard) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-LWP-UserAgent-DNS-Hosts-0.08-1.fc26.noarch.rpm | sort | uniq -c 1 perl(LWP::Protocol::http::hosts) 1 perl(LWP::Protocol::https::hosts) 1 perl(LWP::UserAgent::DNS::Hosts) = 0.08 1 perl-LWP-UserAgent-DNS-Hosts = 0.08-1.fc26 Binary provides are Ok. $ rpmlint ./perl-LWP-UserAgent-DNS-Hosts* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok FIX: Please add missing build requires - make (spec file, lines 45, 49, 55) - findutils (spec file, line 50) - in case you do not remove the command - perl(Carp) - lib/LWP/UserAgent/DNS/Hosts.pm:6 - perl(strict) - perl(warnings) FIX: Remove all the bundled Module::Install files from ./inc, build-require `perl(inc::Module::Install)' and other needed modules from Module::Install namespace (locate functions called from Makefile.PL). Or declare all build-time dependencies for the bundled Module::Install modules. TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. TODO: Use plain 'perl' command instead of %{__perl} macro and build-require 'perl'. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Package NOT approved.
Thanks for the feedback, I'm working on correcting those dings. One question though. Regarding "Use plain 'perl' command", the current Perl packaging guidelines [1] require the following line: > Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) Should the guidelines be updated to s/%{__perl}/perl/ on that requirement? [1]: https://fedoraproject.org/wiki/Packaging:Perl
I'll hold off on that TODO item, pending clarification of the Perl packaging guidelines. Everything else has been fixed, please review. Spec URL: https://carlgeorge.fedorapeople.org/perl-LWP-UserAgent-DNS-Hosts/perl-LWP-UserAgent-DNS-Hosts.spec SRPM URL: https://carlgeorge.fedorapeople.org/perl-LWP-UserAgent-DNS-Hosts/perl-LWP-UserAgent-DNS-Hosts-0.08-2.fc26.src.rpm
> FIX: Please add missing build requires > - make (spec file, lines 45, 49, 55) > - findutils (spec file, line 50) - in case you do not remove the command > - perl(Carp) - lib/LWP/UserAgent/DNS/Hosts.pm:6 > - perl(strict) > - perl(warnings) Fixed > FIX: Remove all the bundled Module::Install files from ./inc, build-require > `perl(inc::Module::Install)' and other needed modules from Module::Install > namespace (locate functions called from Makefile.PL). Or declare all > build-time dependencies for the bundled Module::Install modules. FIX: There are missing two build requires perl(Module::Install::Metadata) - name, license, all_from, tests, ... perl(Module::Install::WriteAll) - WriteAll > > TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. Fixed. Please add two missing build-requires. Otherwise package looks good. Approved
I just added those last two build requires in a -3 release. Thanks for the review!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-LWP-UserAgent-DNS-Hosts