Bug 1364170 - Review Request: nodejs-expand-range - Fast, bash-like range expansion
Summary: Review Request: nodejs-expand-range - Fast, bash-like range expansion
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1433775 1433776 (view as bug list)
Depends On: 1347899 1444628
Blocks: nodejs-reviews 1364172 Node-RED 1433764
TreeView+ depends on / blocked
 
Reported: 2016-08-04 15:38 UTC by Jared Smith
Modified: 2017-09-26 18:14 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-26 18:14:53 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2016-08-04 15:38:43 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expand-range/nodejs-expand-range.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expand-range/nodejs-expand-range-1.8.2-1.fc26.src.rpm
Description: Fast, bash-like range expansion
Fedora Account System Username: jsmith
Comment 1 Jared Smith 2017-04-17 14:21:17 UTC 
*** Bug 1433776 has been marked as a duplicate of this bug. ***
Comment 2 Jared Smith 2017-04-17 14:21:49 UTC 
*** Bug 1433775 has been marked as a duplicate of this bug. ***
Comment 3 Jared Smith 2017-05-09 22:11:00 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expand-range/nodejs-expand-range.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expand-range/nodejs-expand-range-2.0.1-1.fc27.src.rpm
Comment 4 Robert-André Mauchin 🐧 2017-09-22 15:11:45 UTC 
Tests fails:

  17 passing (14ms)
  4 failing
  1) character classes: should return a string for a regex range when `true` is passed::
     AssertionError [ERR_ASSERTION]: [ '[a-e]' ] deepEqual '[a-e]'
      at Context.<anonymous> (test.js:108:12)
  2) character classes: should flip order when a sequential range is backwards:
     AssertionError [ERR_ASSERTION]: [ '(1023|1022|1021)' ] deepEqual '102[1-3]'
      at Context.<anonymous> (test.js:116:12)
  3) character classes: should return null for invalid patterns::
     AssertionError [ERR_ASSERTION]: null deepEqual []
      at Context.<anonymous> (test.js:124:12)
  4) when a custom function is used for expansions should expose the index:
      AssertionError [ERR_ASSERTION]: [ 'a', 'b', 'c', 'd', 'e' ] deepEqual [ 'a0', 'b1', 'c2', 'd3', 'e4' ]
      + expected - actual
       [
      +  "a0"
      +  "b1"
      +  "c2"
      +  "d3"
      +  "e4"
      -  "a"
      -  "b"
      -  "c"
      -  "d"
      -  "e"
       ]
      
      at Context.<anonymous> (test.js:168:12)
Comment 5 Robert-André Mauchin 🐧 2017-09-22 16:13:48 UTC 
Needs an update of npm(fill-range) >= 4.0.0 (bug #1444628)
Comment 6 Robert-André Mauchin 🐧 2017-09-23 11:35:10 UTC 
Works in Koji.

Package accepted.
Comment 7 Jared Smith 2017-09-24 00:32:42 UTC 
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1575'
Comment 8 Gwyn Ciesla 2017-09-24 17:31:07 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-expand-range
Comment 9 Jared Smith 2017-09-26 18:14:53 UTC 
In rawhide, closing bug
Note You need to log in before you can comment on or make changes to this bug.