Bug 1364211 - Review Request: nodejs-tad - JavaScript test suite
Summary: Review Request: nodejs-tad - JavaScript test suite
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jeroen van Meeuwen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1356395
Blocks: nodejs-reviews 1364212 Node-RED
TreeView+ depends on / blocked
 
Reported: 2016-08-04 17:57 UTC by Jared Smith
Modified: 2016-10-21 08:13 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-08-09 14:43:14 UTC
Type: ---
Embargoed:
vanmeeuwen+fedora: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2016-08-04 17:57:10 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tad/nodejs-tad.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tad/nodejs-tad-0.2.4-2.fc26.src.rpm
Description: JavaScript test suite
Fedora Account System Username: jsmith
Comment 1 Jeroen van Meeuwen 2016-08-05 10:12:56 UTC 
nodejs-tad.noarch: E: script-without-shebang /usr/lib/node_modules/tad/lib/configure.js
nodejs-tad.noarch: E: script-without-shebang /usr/lib/node_modules/tad/lib/load.js
nodejs-tad.noarch: E: script-without-shebang /usr/lib/node_modules/tad/lib/find-test-path.js
nodejs-tad.noarch: E: script-without-shebang /usr/lib/node_modules/tad/lib/utils/index-test.js
nodejs-tad.noarch: E: script-without-shebang /usr/lib/node_modules/tad/index.js
Comment 2 Jared Smith 2016-08-05 22:47:34 UTC 
Fixed. 

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tad/nodejs-tad.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tad/nodejs-tad-0.2.4-2.fc26.src.rpm
Comment 3 Jeroen van Meeuwen 2016-08-06 08:36:50 UTC 
Please re-upload a spec and SRPM that match in NEVRA (spec is -3, srpm is still -2, and what you fixed in the spec "isn't fixed" in the SRPM).
Comment 4 Jeroen van Meeuwen 2016-08-06 08:37:40 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tad/nodejs-tad.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tad/nodejs-tad-0.2.4-3.fc26.src.rpm
Comment 5 Gwyn Ciesla 2016-08-08 14:43:47 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-tad
Comment 6 Jared Smith 2016-08-09 14:43:14 UTC 
In rawhide, closing bug
Note You need to log in before you can comment on or make changes to this bug.