Spec URL: https://raw.githubusercontent.com/dmsimard/python-XStatic-objectpath-distgit/master/python-XStatic-objectpath.spec SRPM URL: https://github.com/dmsimard/python-XStatic-objectpath-distgit/raw/master/python-XStatic-objectpath-1.2.1.0-1.fc24.src.rpm Description: ObjectPath JavaScript library packaged for setuptools (easy_install) / pip. Parse js object paths using both dot and bracket notation. Stringify an array of properties into a valid path. Fedora Account System Username: dmsimard Koji scratch build available at http://koji.fedoraproject.org/koji/taskinfo?taskID=15147527
The scratch build works in koji for both rawhide and f24 but pulling this bugzilla down with fedora-review isn't working and gives the error: === + /usr/bin/python2 setup.py build Traceback (most recent call last): File "setup.py", line 1, in <module> from xstatic.pkg import objectpath as xs ImportError: cannot import name objectpath RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.UVeJZ8 (%build) Bad exit status from /var/tmp/rpm-tmp.UVeJZ8 (%build) Child return code was: 1 === Can't figure it out for the time being, will give a fresh look later.
I'll be sponsoring David, reviews are welcome.
David, it's a known issue, that you can not build xstatic packages, if you have another xstatic package installed on your host. https://bitbucket.org/thomaswaldmann/xstatic/issues/2/cannot-build-a-new-xstatic-package-with
@Matthias, oh, wow.. indeed ! I cleaned the mockroot for the build and now it works. That's a relief and definitely good to know. Thanks.
Spec URL: https://raw.githubusercontent.com/dmsimard/python-XStatic-objectpath-distgit/master/python-XStatic-objectpath.spec SRPM URL: https://github.com/dmsimard/python-XStatic-objectpath-distgit/raw/master/python-XStatic-objectpath-1.2.1.0-1.fc24.src.rpm Description: ObjectPath JavaScript library packaged for setuptools (easy_install) / pip. Parse js object paths using both dot and bracket notation. Stringify an array of properties into a valid path. Fedora Account System Username: dmsimard Koji scratch build available at http://koji.fedoraproject.org/koji/taskinfo?taskID=15158916
Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/haikel/1364607-python-XStatic-objectpath/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -XStatic-objectpath , xstatic-objectpath-common , python3-XStatic- objectpath [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-XStatic-objectpath-1.2.1.0-1.fc28.noarch.rpm xstatic-objectpath-common-1.2.1.0-1.fc28.noarch.rpm python3-XStatic-objectpath-1.2.1.0-1.fc28.noarch.rpm python-XStatic-objectpath-1.2.1.0-1.fc28.src.rpm python2-XStatic-objectpath.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python2-XStatic-objectpath.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python2-XStatic-objectpath.noarch: W: spelling-error %description -l en_US Stringify -> Stringy xstatic-objectpath-common.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python3-XStatic-objectpath.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python3-XStatic-objectpath.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python3-XStatic-objectpath.noarch: W: spelling-error %description -l en_US Stringify -> Stringy python-XStatic-objectpath.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python-XStatic-objectpath.src: W: spelling-error %description -l en_US js -> dis, ks, j python-XStatic-objectpath.src: W: spelling-error %description -l en_US Stringify -> Stringy 4 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- xstatic-objectpath-common.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python2-XStatic-objectpath.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python2-XStatic-objectpath.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python2-XStatic-objectpath.noarch: W: spelling-error %description -l en_US Stringify -> Stringy python3-XStatic-objectpath.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python3-XStatic-objectpath.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python3-XStatic-objectpath.noarch: W: spelling-error %description -l en_US Stringify -> Stringy 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Requires -------- xstatic-objectpath-common (rpmlib, GLIBC filtered): web-assets-filesystem python2-XStatic-objectpath (rpmlib, GLIBC filtered): python(abi) python-XStatic xstatic-objectpath-common python3-XStatic-objectpath (rpmlib, GLIBC filtered): python(abi) python3-XStatic xstatic-objectpath-common Provides -------- xstatic-objectpath-common: xstatic-objectpath-common python2-XStatic-objectpath: python-XStatic-objectpath python2-XStatic-objectpath python2.7dist(xstatic-objectpath) python2dist(xstatic-objectpath) python3-XStatic-objectpath: python3-XStatic-objectpath python3.6dist(xstatic-objectpath) python3dist(xstatic-objectpath) Source checksums ---------------- https://pypi.io/packages/source/X/XStatic-objectpath/XStatic-objectpath-1.2.1.0.tar.gz : CHECKSUM(SHA256) this package : cd1e9f502482afcdd028821148843b07b4065c8dcea8e5cc33abb9ae1cf20b20 CHECKSUM(SHA256) upstream package : cd1e9f502482afcdd028821148843b07b4065c8dcea8e5cc33abb9ae1cf20b20 https://raw.githubusercontent.com/mike-marcacci/objectpath/master/license : CHECKSUM(SHA256) this package : 36d0b025e2940c012ccc2e184de4e5e2927014f9439e2d856e8507c106c862bd CHECKSUM(SHA256) upstream package : 36d0b025e2940c012ccc2e184de4e5e2927014f9439e2d856e8507c106c862bd Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1364607 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
I already sponsored David, so removing FE-NEEDSPONSOR
What's the status here? Since this was a fedora package review, it is possible to get it added to Fedora.
I do not plan on pursuing this review for the time being.