Created attachment 1188131 [details]
Fixed jwhois fclose patch

Description of problem:
When jwhois.conf is not accessible, /usr/bin/jwhois segfaults. This appears to be the result of attempting to erroneously fclose() a null FILE pointer. This is mostly observed in chrooted environments.

Version-Release number of selected component (if applicable):
$ rpm -qa | grep jwhois
jwhois-4.0-44.el7.centos.x86_64
jwhois-debuginfo-4.0-44.el7.x86_64


How reproducible:
Yes

Steps to Reproduce:
1. Install jwhois package
2. Remove /etc/jwhois.conf or otherwise make open("/etc/jwhois.conf", "r") fail
3. `jwhois example.com`

# yum install jwhois -q -y && rm -f /etc/jwhois.conf && ulimit -c unlimited && jwhois example.com
Segmentation fault (core dumped)
#


Actual results:
jwhois segfaults;

 (gdb) bt full
 #0  _IO_new_fclose (fp=0x0) at iofclose.c:54
         status = <optimized out>
 #1  0x0000000000404100 in parse_args (argc=argc@entry=0x7ffd58936eac,
     argv=argv@entry=0x7ffd58936ea0) at init.c:286
         optch = <optimized out>
         option_index = 32583
         ret = 0xa <Address 0xa out of bounds>
         in = <optimized out>
 #2  0x00000000004020e8 in main (argc=2, argv=0x7ffd58937008) at jwhois.c:95
         optind = <optimized out>
         count = 0
         ret = 0
         rc = 0
         qstring = 0x0
         text = 0x7ffd58936f30 ""
         idn = 0x7ffd58936f40 ""
         wq = {host = 0x0, port = 0, query = 0x0, domain = 0x0}



Expected results:
whois text printed to stdout

Additional info:
It looks like the issue is within jwhois-4.0-fclose.patch which has an fclose call outside the scope of the proceeding null pointer check. I was able to rebuild the sRPM with the attached patch, which appears to correct the issue. I have selected el7, since that applies to the package I replicated the issue with; however, the issue was originally observed on a system which uses el6, and I would expect any RPM with this patch applied to be affected.