Bug 1364739 - Fix sensitivity to rw,ro ordering in the exports file
Summary: Fix sensitivity to rw,ro ordering in the exports file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: mainline
Hardware: Unspecified
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-06 20:36 UTC by Shreyas Siravara
Modified: 2023-09-14 03:29 UTC (History)
3 users (show)

Fixed In Version: glusterfs-4.1.3 (or later)
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-29 03:37:50 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)
Suggested Patch (4.30 KB, patch)
2016-08-06 20:36 UTC, Shreyas Siravara
no flags Details | Diff

Description Shreyas Siravara 2016-08-06 20:36:48 UTC
Created attachment 1188254 [details]
Suggested Patch

Description of problem:

When a netgroup is marked as rw in the exports file, and another netgroup is marked as ro for the same share, the ro option is not honored.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create an exports file with a netgroup which has one client with 'ro' permission, and one client with 'rw' permission.
2. Mount this share from the two clients and attempt to write data.

Actual results: 
Only one of the 'ro' or 'rw' options is honored.

Expected results:
The appropriate 'ro' and 'rw' options for each client must be honored.


Additional info:

Comment 2 Vijay Bellur 2016-08-06 21:27:27 UTC
REVIEW: http://review.gluster.org/15104 (nfs/auth: Fix sensitivity to rw,ro ordering in the exports file) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 3 Niels de Vos 2016-08-06 21:29:18 UTC
Thanks Shreyas! Could you check if the posted patch works for you too? It should prevent the extra execution of __export_dir_lookup_netgroup() after an entry was matched.

Comment 4 Vijay Bellur 2016-08-06 21:36:38 UTC
REVIEW: http://review.gluster.org/15104 (nfs/auth: Fix sensitivity to rw,ro ordering in the exports file) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 5 Amar Tumballi 2018-08-29 03:37:50 UTC
This update is done in bulk based on the state of the patch and the time since last activity. If the issue is still seen, please reopen the bug.

Comment 6 Red Hat Bugzilla 2023-09-14 03:29:12 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.