Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1364804

Summary: [engine-backend] Compensation context data is cleared although the data wasn't reverted on parent-child command scenario
Product: [oVirt] ovirt-engine Reporter: Liron Aravot <laravot>
Component: BLL.InfraAssignee: Ravi Nori <rnori>
Status: CLOSED CURRENTRELEASE QA Contact: Ravi Nori <rnori>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.0.2CC: acanan, bugs, ebenahar, gklein, mgoldboi, mperina, talayan
Target Milestone: ovirt-4.0.4Keywords: CodeChange
Target Release: 4.0.4Flags: rule-engine: ovirt-4.0.z+
mgoldboi: planning_ack+
mperina: devel_ack+
pstehlik: testing_ack+
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1359788 Environment:
Last Closed: 2016-09-26 10:57:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1359788    
Bug Blocks:    

Description Liron Aravot 2016-08-07 17:42:00 UTC 
Description of problem:
When the compensation is passed to a child command from a parent command, on failure of the child command the data registered on the compensation context will be cleared although it wasn't actually reverted.

Detailed description:
1.When the compensation context is created for the parent command, it's created with the parent command id (so entities registered to it are registered with the parent id). 

2. Compensation data is registered and saved to the db using the parent command id.

3. The child command fails.

2. We attempt to revert on the failure of the child command, the data to revert is queried from the db using the child command id, as the entities were registered with the parent id no results returns and no data is reverted.

3. All the compensation data is cleared, so the entities registered with the parent id are cleared as well.

4. Compensation context rollback is running for the parent command, as the compensation data was deleted from the db there's nothing to revert.

How reproducible:
Always

Steps to Reproduce:
1. Create new data center, it'll be added in uninitialized status.
2. Add cluster/host and activate the host
3. Make sure that CreateStoragePoolVDS command will fail (can be done by simulating a failure)


Actual results:
The compensation data isn't reverted.


Expected results:
The compnsation data should be reverted.
+++ This bug was initially created as a clone of Bug #1359788 +++
Comment 1 Red Hat Bugzilla Rules Engine 2016-08-07 17:42:09 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 2 Red Hat Bugzilla Rules Engine 2016-08-07 17:42:35 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 4 Martin Perina 2016-08-16 10:47:32 UTC 
Moving back to POST as we need to backport to ovirt-engine-4.0
Comment 5 Gil Klein 2016-09-26 10:57:13 UTC 
Closed as a Code change