Bug 1365399 - Review Request: python-aaargh - An astonishingly awesome application argument helper
Summary: Review Request: python-aaargh - An astonishingly awesome application argument...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1323365
TreeView+ depends on / blocked
 
Reported: 2016-08-09 07:49 UTC by Dominika Krejčí
Modified: 2017-05-31 09:02 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-18 21:19:44 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)

Description Dominika Krejčí 2016-08-09 07:49:25 UTC
Spec URL: https://dkrejci.fedorapeople.org/python-aaargh/python-aaargh.spec
SRPM URL: https://dkrejci.fedorapeople.org/python-aaargh/python-aaargh-0.7.1-1.fc24.src.rpm
Description: An astonishingly awesome application argument helper
Fedora Account System Username: dkrejci

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15183541

Comment 1 Igor Gnatenko 2016-08-09 07:56:26 UTC
> %license PKG-INFO
it's not license and doesn't contain any interesting stuff, so drop it

> %{python2_sitelib}/%{srcname}/*.py*
> %{python3_sitelib}/%{srcname}/__pycache__/
> %{python3_sitelib}/%{srcname}/*.py
and who owns base directory?

> BuildRequires:  python2-devel
> BuildRequires:  python3-devel
move under subpakcages.

* Tests are present, but not ran
* Missing BuildRequires: pythonX-setuptools
* Don't copy-paste description, do something like:
> %global description \
> foo bar\
> baz.
> %description %{_description}
> %description -n python2-%{srcname} %{_description}
> 
> Python 2 version
> ...

Comment 3 Igor Gnatenko 2016-08-09 08:59:19 UTC
> BuildRequires:  python-pytest-cov
> BuildRequires:  python3-pytest-cov
you can drop this

> %description
> %{desc}
squash such things to one line, otherwise description will have one extra empty line.

> py.test-2
> py.test-3
I would add "-v" to simplify degugging if something will go wrong

Comment 5 Igor Gnatenko 2016-08-09 10:50:08 UTC
you forgot to fix:

> %description -n python2-%{srcname}
> %{desc}

same for python3

Comment 7 Gwyn Ciesla 2016-08-09 13:06:00 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-aaargh

Comment 8 Fedora Update System 2016-08-10 09:26:40 UTC
python-aaargh-0.7.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ef25ffb8cc

Comment 9 Fedora Update System 2016-08-10 09:26:48 UTC
python-aaargh-0.7.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c644fccf82

Comment 10 Fedora Update System 2016-08-10 09:26:52 UTC
python-aaargh-0.7.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a091e9df72

Comment 11 Fedora Update System 2016-08-10 18:55:21 UTC
python-aaargh-0.7.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a091e9df72

Comment 12 Fedora Update System 2016-08-10 19:53:11 UTC
python-aaargh-0.7.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ef25ffb8cc

Comment 13 Fedora Update System 2016-08-11 03:24:36 UTC
python-aaargh-0.7.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c644fccf82

Comment 14 Fedora Update System 2016-08-18 21:19:42 UTC
python-aaargh-0.7.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2016-08-18 23:19:04 UTC
python-aaargh-0.7.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2017-05-31 09:02:15 UTC
python-aaargh-0.7.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.