Bug 1365427 - engine-setup asks about scale also on upgrade/restore from 3.6
Summary: engine-setup asks about scale also on upgrade/restore from 3.6
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dwh
Classification: oVirt
Component: Setup
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.0.5
: 4.0.5
Assignee: Yedidyah Bar David
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks: 1379120
TreeView+ depends on / blocked
 
Reported: 2016-08-09 09:00 UTC by Yedidyah Bar David
Modified: 2017-05-11 09:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: In 4.0, dwh engine-setup plugin prompts the user to choose between 'Full' and 'Basic' scale. If dwh is on the same machine as the engine, it defaults to 'Basic'. In past 4.0 releases, it always asked this question on upgrade from 3.6. Consequence: If dwh was already set up in 3.6, and used the default configuration, which is equivalent to 4.0's 'Full', and the user didn't pay attention to this question and pressed Enter, configuration was changed to 'Basic', potentially removing most of the history data collected. Fix: Now this question is asked, and scale is configured, only if this is a new dwh database setup, and not if the database already exists, e.g. not if it is an upgrade. Result: On upgrade, this question is not asked, configuration is not changed, and history data is not removed.
Clone Of:
Environment:
Last Closed: 2017-01-18 07:38:19 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.0.z+
ylavi: planning_ack+
sbonazzo: devel_ack+
lsvaty: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 63642 0 master MERGED packaging: setup: Configure scale only on new database 2016-09-18 12:32:28 UTC
oVirt gerrit 63736 0 ovirt-engine-dwh-4.0 MERGED packaging: setup: Configure scale only on new database 2016-09-19 13:52:56 UTC

Description Yedidyah Bar David 2016-08-09 09:00:20 UTC 
Description of problem:

In bug 1328805 we added a question about scale.

We ask this question also during upgrade from 3.6, including if restoring a 3.6 backup on a 4.0 system.

Not sure about the perfect solution. One might even claim it's not a bug.

In 3.6 we didn't have this question, so do not know the answer. Current 'Full' was the default then, and changing it required manually editing config files.

Perhaps changing the prompt text is enough.

A "full" (but somewhat hacky) solution can be to check current conf, and ask if different from default. Note that in 4.0 the default depends on whether dwh is with the engine on same machine - "Basic" if yes, "Full" if different machines.

A related question (might be worth another bug) is that we always rewrite the configuration on upgrade. So a user manually changing the conf after running engine-setup will have the changes overwritten by a next upgrade. This isn't specific to the dwh scale params, it applies to many other questions.
Comment 1 Yaniv Lavi 2016-08-11 08:36:12 UTC 
We should keep it as 'full' in upgrades that had DWH previously installed in 3.6 or even better ask and have 'full' as default option.
In any case in fresh install or upgrade without DWH, we need to ask.
Comment 2 Yedidyah Bar David 2016-09-11 13:08:00 UTC 
Thinking about this again, I think it's enough if we only ask this question, and configure scale, if we are setting up a new database. On any setup with existing database (upgrade, migration, etc.) we do nothing. dwhd will then use its defaults or whatever manual configuration the admin did.
Comment 3 Shirly Radco 2016-09-11 19:28:31 UTC 
But when do we set the sampling interval to 15 instead of 60?
Is this done in a separate step?
Comment 4 Yedidyah Bar David 2016-09-12 06:31:54 UTC 
(In reply to Shirly Radco from comment #3)
> But when do we set the sampling interval to 15 instead of 60?
> Is this done in a separate step?

When? On upgrade? Never.

On clean setup - same as today.

Do we have to do anything on upgrade?
Comment 5 Shirly Radco 2016-09-12 17:47:51 UTC 
Yes. We should update the sampling interval to 15 seconds same as in clean setup.
This is for better dashboards accuracy.
Comment 6 Yedidyah Bar David 2016-09-13 05:43:34 UTC 
(In reply to Shirly Radco from comment #5)
> Yes. We should update the sampling interval to 15 seconds same as in clean
> setup.
> This is for better dashboards accuracy.

Which parameter exactly?
Comment 7 Shirly Radco 2016-09-13 08:53:44 UTC 
Please disregard. It is unrelated and already addressed it.
Comment 8 Lukas Svaty 2016-10-18 15:54:17 UTC 
verified in ovirt-engine-dwh-setup-4.0.2-1.el7ev.noarch
Note You need to log in before you can comment on or make changes to this bug.