Bug 1365535 - Review Request: entr - Run arbitrary commands when files change
Summary: Review Request: entr - Run arbitrary commands when files change
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-09 13:21 UTC by Lubomír Sedlář
Modified: 2016-08-29 16:03 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-29 16:03:02 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)
suggested patch for spec (1.91 KB, patch)
2016-08-26 15:32 UTC, Igor Gnatenko
no flags Details | Diff

Description Lubomír Sedlář 2016-08-09 13:21:37 UTC
Spec URL: https://lsedlar.fedorapeople.org/entr/entr.spec
SRPM URL: https://lsedlar.fedorapeople.org/entr/entr-3.6-5.fc24.src.rpm
Description:
A utility for running arbitrary commands when files change. Uses inotify to avoid polling. It was written to make rapid feedback and automated testing natural and completely ordinary.

Fedora Account System Username: lsedlar
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15187775
I have also been maintaining the package in COPR for a while now:
https://copr.fedorainfracloud.org/coprs/lsedlar/entr/

Comment 1 Igor Gnatenko 2016-08-26 15:31:08 UTC
Suggested patch for spec is coming.

Comment 2 Igor Gnatenko 2016-08-26 15:32:11 UTC
Created attachment 1194406 [details]
suggested patch for spec

I found some number of issues in spec so I fixed them for you.

Comment 3 Lubomír Sedlář 2016-08-29 06:03:25 UTC
Thank you for the patch, the changes look very reasonable to me. (I admit I was struggling with the %setup part, and your version is much simpler than mine).

Spec: https://lsedlar.fedorapeople.org/entr/entr.spec
SRPM: https://lsedlar.fedorapeople.org/entr/entr-3.6-6.fc24.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15423416

Comment 4 Igor Gnatenko 2016-08-29 06:42:45 UTC
Missing BuildRequires: gcc

Comment 6 Gwyn Ciesla 2016-08-29 12:52:37 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/entr


Note You need to log in before you can comment on or make changes to this bug.