Bug 1365683 - Fix crash bug when mnt3_resolve_subdir_cbk fails
Summary: Fix crash bug when mnt3_resolve_subdir_cbk fails
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1365599 1380692
TreeView+ depends on / blocked
 
Reported: 2016-08-09 20:42 UTC by Niels de Vos
Modified: 2017-12-08 17:31 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.13.0
Clone Of: 1365599
Environment:
Last Closed: 2017-12-08 17:31:43 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2016-08-09 20:42:47 UTC
+++ This bug was initially created as a clone of Bug #1365599 +++

Description of problem:
When mnt3_resolve_subdir_cbk() fails, authorized_path is sometimes NULL. We try to run strlen() on this path and as a result we crash.


Version-Release number of selected component (if applicable): 3.8

Comment 1 Vijay Bellur 2016-08-09 20:45:06 UTC
REVIEW: http://review.gluster.org/15121 (nfs: Fix crash bug when mnt3_resolve_subdir_cbk() fails) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Worker Ant 2017-11-01 13:31:19 UTC
COMMIT: https://review.gluster.org/15121 committed in master by  

------------- nfs: Fix crash bug when mnt3_resolve_subdir_cbk() fails

Summary:
When mnt3_resolve_subdir_cbk() fails (this can happen when racing
operations), authorized_path is sometimes NULL. We try to run strlen()
on this path and as a result we crash. This diff fixes that by checking
if path is NULL before dereferencing it.

Test Plan: Run with patch and observe that there is no crash. Prove test
for auth code.

BUG: 1365683
Change-Id: I2e2bdfdc61ae906788611e151d2c753b79b312df
Signed-off-by: Shreyas Siravara <sshreyas>

Comment 3 Shyamsundar 2017-12-08 17:31:43 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.