Created attachment 1189516 [details] events in web admin gui when engine-backup command has been executed Description of problem: When running engine-backup --mode=backup you get generic event messages in web admin gui, wthout being able to correlate with the action executed Version-Release number of selected component (if applicable): ovirt-engine-tools-backup-4.0.0.6-1.el7.centos.noarch How reproducible: always Steps to Reproduce: 1. run command engine-backup --mode=backup --scope=all --file=/root/engine-backup.archive_$(date +%d-%m-%Y) --log=/root/engine-backup_$(date +%d-%m-%Y).log Backing up: Notifying engine - Files - Engine database 'engine' - DWH database 'ovirt_engine_history' Packing into file '/root/engine-backup.archive_09-08-2016' Notifying engine Done. 2. you get several events in webadmin gui (see attachment) but without any information. Only rows of kind: Finished Started 3. Actual results: No correlation between web admin gui events and backup action executed Expected results: Something informational in web admin gui events Additional info:
Not sure about the best solution, moving to Integration for now.
engine-backup calls: SELECT LogEngineBackupEvent('${scope}', now(), ${status}, '${message}', '${ENGINE_FQDN}', '${logpath}'); Where: - scope is one of files, db, dwhdb, reportsdb - status is one of -1, 0, 1 - message is one of 'Started', 'Finished', 'Failed', or an error message - The rest are as expected Since engine-backup is not localized, I didn't include longer messages, expecting the db or engine to show something nicer to the user somehow. LogEngineBackupEvent inserts both into engine_backup_log and into audit_log. IIUC current bug is about the ui view of audit_log. Not sure if engine_backup_log is user-viewable anywhere, or only used for monitoring backup status. I can think of several solutions: 1. Patch engine-backup to have longer messages, but not localized 2. Patch LogEngineBackupEvent or some other db function to do this, no idea if can be localized 3. Keep existing texts in the db and patch the engine to display nicer ones, either in existing audit_log view or in a new engine_backup_log view. Eli, what do you think?
(In reply to Yedidyah Bar David from comment #2) > 1. Patch engine-backup to have longer messages, but not localized > 2. Patch LogEngineBackupEvent or some other db function to do this, no idea > if can be localized > 3. Keep existing texts in the db and patch the engine to display nicer ones, > either in existing audit_log view or in a new engine_backup_log view. > > Eli, what do you think? I would go for option #1 You can simply check the SCOPE_* in packaging/bin/engine-backup.sh.in::dobackup() and according to that provide more detailed message
Please add more meaningful text on the engine side with translations.
(In reply to Eli Mesika from comment #3) > I would go for option #1 > You can simply check the SCOPE_* in > packaging/bin/engine-backup.sh.in::dobackup() and according to that provide > more detailed message Moving to integration going with option #1
(In reply to Sandro Bonazzola from comment #5) > (In reply to Eli Mesika from comment #3) > > I would go for option #1 > > You can simply check the SCOPE_* in > > packaging/bin/engine-backup.sh.in::dobackup() and according to that provide > > more detailed message > > Moving to integration going with option #1 Sorry, didn't see Yaniv request, back to infra.
*** This bug has been marked as a duplicate of bug 1372320 ***