Red Hat Bugzilla – Bug 1365903
virt-admin reports a message indicating success when it fails to connect
Last modified: 2016-11-03 14:52:11 EDT
Description of problem: When virt-admin fails to connect, e.g. due to an invalid URI, it does report an error stating that it failed to connect but at the same time it reports a message indicating that the connection establishment went just fine. Version-Release number of selected component (if applicable): libvirt-2.0.0 and up How reproducible: Always. Steps to Reproduce: 1. launch virt-admin and try to connect to an invalid URI # virt-admin connect foobar error: Failed to connect to the admin server Connected to the admin server error: unsupported configuration: Unsupported URI scheme '<null>' Actual results: As the output indicates, the client apparently both failed an succeeded to connect to the given URI. Expected results: The output of virt-admin only reports an error in the above case.
Fixed upstream by: commit 4914494eb8e25ff7938a12fd089c746ec6042bbb Author: Erik Skultety <eskultet@redhat.com> AuthorDate: Tue Aug 9 16:11:26 2016 +0200 Commit: Erik Skultety <eskultet@redhat.com> CommitDate: Wed Aug 10 15:24:07 2016 +0200 virt-admin: Fix the error when an invalid URI has been provided After commit 9d479dd1 fiddled with the cmdConnect's output which used to be a bit more verbose prior to the mentioned commit, the program flow would result in a quite confusing error if an invalid URI has been provided: error: Failed to connect to the admin server Connected to the admin server error: <some error> The problem is that the commit mentioned above relied on the fact that connect routine always succeeds which is not true. Signed-off-by: Erik Skultety <eskultet@redhat.com>
Reproduced on build libvirt-2.0.0-4.el7.x86_64 # virt-admin connect aaa error: Failed to connect to the admin server Connected to the admin server error: unsupported configuration: Unsupported URI scheme '<null>' Verify on build libvirt-2.0.0-5.el7.x86_64 # virt-admin connect aaa error: Failed to connect to the admin server error: unsupported configuration: Unsupported URI scheme '<null>' # echo $? 1
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-2577.html