(In reply to Radek Vykydal from comment #0)
 
> --- Additional comment from Radek Vykydal on 2016-07-29 05:46:24 EDT ---
> 
> Seems that NetworkManager started to require non-empty team port
> configration when creating team slave configuration (compared to 7.2 where
> empty port configuration would be accepted).
> 
> We can fix it by this patch:
> 
> https://github.com/rhinstaller/anaconda/pull/717
> 
> I'd just like to confirm from NM whether the change is really intentional?
> 
> --- Additional comment from Radek Vykydal on 2016-07-29 05:50:22 EDT ---
> 
> Updates image with the patch for anaconda-21.48.22.80-1.el7.x86_64:
> https://rvykydal.fedorapeople.org/updates.teamreg73.img
> 
> Updates image with the patch for the latest
> anaconda-21.48.22.81-1.el7.x86_64:
> https://rvykydal.fedorapeople.org/updates.teamreg73.81.img
> 
> --- Additional comment from Lubomir Rintel on 2016-08-01 11:41:01 EDT ---
> 
> I think we want to preserve the ability to specify empty configuration.

So cloning for NM.

previously we did not verify the json value at all, now we do.

It is clear that tightening up the verification, leads to rejecting values that were considered valid before.
One question is whether that is acceptable in general, and whether there are certain values (like "") for which this change is inacceptable.

Yeah, maybe "" should be treated like "{}" to be more graceful here.

Created attachment 1193512 [details]
[patch] handle empty team config as valid

was originally posted by lrintel for bug 1366300

Just a note: regarding the "" value we (anaconda) are okay with either way you choose. A fix on our side is easy.

fix merged after ACK from Beniamino

master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=eb982b9d9442085abc825df7797f4679f7c7c53c

nm-1-4: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=890c37ebd0e98a4409f3d43f6253a78ee1bcb37f

(In reply to Radek Vykydal from comment #6)
> Just a note: regarding the "" value we (anaconda) are okay with either way
> you choose. A fix on our side is easy.

yeah, but it cause connections from older versions to be rejected as invalid after upgrade. Also, breaking older clients should be avoided as well.

nmcli connection add type team con-name team0 ifname nm-team autoconnect no team.config "" is now accepted

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2581.html