RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1366307 - [pcsd] Badly designed usage of HTML ID attributes may cause unexpected behavior with certain resource names
Summary: [pcsd] Badly designed usage of HTML ID attributes may cause unexpected behavi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.3
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: rc
: ---
Assignee: Ondrej Mular
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-11 14:46 UTC by Radek Steiger
Modified: 2016-11-03 20:59 UTC (History)
5 users (show)

Fixed In Version: pcs-0.9.152-7.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 20:59:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2596 0 normal SHIPPED_LIVE Moderate: pcs security, bug fix, and enhancement update 2016-11-03 12:11:34 UTC

Description Radek Steiger 2016-08-11 14:46:20 UTC
> Description of problem:

ID attribute of HTML elements that represent each resource in the GUI resource list is generated dynamically according to the resource name, but instead of using a deterministic pre/post-fix or a completely random and therefore unique ID it only takes the corresponding resource's name and uses it as an ID. This enables the user to create such a resource which name used as an ID would collide with some other ID that already exists inside the GUI page, possibly causing an unexpected behavior.

The most simple reproducer is to create a resource called 'test'. As the ID 'test' is already reserved by parts of the javascript framework the result of this particular case is making the resource non-highlightable within the resource list.

Another one is to use browser's developer tools and xpath to search for particular ID, i.e. run $x("//*[@id='test']") in Chrome's console to verify that ID is present more than once.


> Version-Release number of selected component (if applicable):

pcs-0.9.152-6.el7.x86_64


> Steps to Reproduce:

1. Create a resource called 'test'
2. Try to highlight the resource inside resource list


> Actual results:

Item cannot be highlighted. Also, an xpath search would return more than one instance of the correspondent ID.


> Expected results:

Item can be highlighted. Also, an xpath search would return just one instance of the correspondent ID.

Comment 1 Ondrej Mular 2016-08-15 13:33:12 UTC
proposed fix:
https://github.com/ClusterLabs/pcs/commit/f1e6da86be122fd2177f70422b3dcb8acd30

Test:
Create resource called 'test'.
In web UI select resource 'test'. It is highlighted.

Comment 2 Ivan Devat 2016-08-19 12:32:38 UTC
Setup:
Create resource called 'test'.


Before Fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.152-6.el7.x86_64
In web UI select resource 'test'. It is not highlighted.


After Fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.152-7.el7.x86_64
In web UI select resource 'test'. It is highlighted.

Comment 6 errata-xmlrpc 2016-11-03 20:59:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2596.html


Note You need to log in before you can comment on or make changes to this bug.