Description of problem: For imagestream has no layers it's better to show message indicating no layers Version-Release number of selected component (if applicable): v3.3.0.18 How reproducible: Always Steps to Reproduce: 1. Create a project and add ImageStreams # oc create -f https://raw.githubusercontent.com/openshift/origin/master/examples/image-streams/image-streams-rhel7.json 2. Select imagestream python:2.7 3. Check imagestream layers # oc get istag python:2.7 -o yaml image: dockerImageLayers: null 4. Go to Layers tab of python:2.7 Actual results: 4. A blank frame is displayed Expected results: 4. Should give some message telling no layers Additional info:
Created attachment 1190346 [details] BlankLayersTab
Stef the fix for this would have to be in the registry-image-layers directive
Are there really no layers? An image should have at least one layer, correct? If so, the message should reflect that reality.
Hi Stef, I defined python:2.7 as no layers because image.dockerImageLayers is null for python:2.7, this is different from other imagestreams like ruby-22-centos7:latest in my example. Please correct me if anything wrong Here is yaml of python:2.7 $ oc get istag python:2.7 -o yaml apiVersion: v1 generation: 2 image: dockerImageLayers: null dockerImageMetadata: Architecture: amd64 And here is yaml of generated(create app) imagestream ruby-22-centos7:latest $ oc get istag ruby-22-centos7:latest -o yaml apiVersion: v1 generation: 2 image: dockerImageLayers: - mediaType: application/vnd.docker.container.image.rootfs.diff+x-gtar name: sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4 size: 0 <.....snip...>
Hi Stef, could you please help check my comment above?
Thanks for the reproducer. Lets just hide the entire 'layers' box in that case.
Fix: https://github.com/openshift/origin-web-console/pull/400
The importer seems to be at fault here. dockerImageLayers shall not be empty for any valid image having layers. And clearly, referenced image [1] does have layers and can be pulled manually using docker 1.10 just fine. [1] registry.access.redhat.com/rhscl/python-27-rhel7:latest I'll investigate. Let me clone the bz to Image component.
Changed product to ORIGIN then we could verify changes earlier and found potential issues as early as possible
moving back to ASSIGNED since no fix has gone in yet. we are figuring out of this is something we need to handle or not
Fix merging to origin in https://github.com/openshift/origin/pull/10549
Now for imagestreams without layers, It will show "No layer information is available for this image" This is more clear than blank 'layers' box Move to VERIFIED since it make sense to me