Bug 1366697 - python-oslo-rootwrap: Handle renamed executables with KillFilter
Summary: python-oslo-rootwrap: Handle renamed executables with KillFilter
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-oslo-rootwrap
Version: 5.0 (RHEL 7)
Hardware: x86_64
OS: Linux
high
high
Target Milestone: async
: 5.0 (RHEL 7)
Assignee: Victor Stinner
QA Contact: Shai Revivo
URL:
Whiteboard:
Depends On:
Blocks: 1368473 1368475 1368476
TreeView+ depends on / blocked
 
Reported: 2016-08-12 15:26 UTC by Aaron Thomas
Modified: 2019-12-16 06:24 UTC (History)
6 users (show)

Fixed In Version: python-oslo-rootwrap-1.0.0-3.el7ost
Doc Type: Bug Fix
Doc Text:
Cause, Consequence: After an upgrade of a service, oslo.rootwrap is unable to stop the service anymore because the executable was replaced (renamed). Fix: Handle renamed executables: use /proc/$pid/cmdline if it exists, instead of /proc/$pid/exe. Result: oslo.rootwrap is now able to stop properly a service after an upgrade, when the executable was replaced (renamed).
Clone Of:
: 1368473 1368475 1368476 (view as bug list)
Environment:
Last Closed: 2016-08-24 14:49:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1771 0 normal SHIPPED_LIVE Red Hat Enterprise Linux OpenStack Platform 5 Bug Fix and Enhancement Advisory 2016-08-24 18:49:36 UTC

Description Aaron Thomas 2016-08-12 15:26:03 UTC
Description of problem:
-----------------------------------------
A running process may refer to a renamed executable
referenced by /proc/$pid/exe, which happens with
updated executables on RPM based systems.
In that case we defer to the path in /proc/$pid/cmdline
if it exists.

Cisco is reporting after upgrading rpms they have to clean up stale pids around the neutron dhcp agent service and requesting a backport upstream python-oslo-rootwrap fix to OSP-5 (Icehouse) which was fixed in python-oslo-rootwrap 2.3.0 currently we ship in OSP-8 (Liberty), see additional details for the specific upstream merged commit. 
 

Version-Release number of selected component (if applicable):
-----------------------------------------
python-oslo-rootwrap-1.0.0-2

How reproducible:
-----------------------------------------
100% in customers environment

Steps to Reproduce:
-----------------------------------------
1. Update an rpm.

2. A running process refers to a renamed executable referenced by /proc/$pid/exe triggering the KillFilter error.

3. The neutron-dhcp-agent.service's pids are in a stale state requiring clean up. 

Actual results:
-----------------------------------------
The customer reports after upgrading rpms they have to clean up stale pids around the neutron dhcp agent service.

Expected results:
------------------------------------------
Oslo Rootwrap should in the case of an rpm upgrade defer to the path in /proc/$pid/cmdline if it exists. 


Additional info:
-----------------------------------------
Upstream merged commit for liberty:


Handle renamed executables with KillFilter
-----------------------------------------
https://review.openstack.org/#/c/210541/3

Comment 4 Victor Stinner 2016-08-19 12:55:59 UTC
python-oslo-rootwrap-1.0.0-3.el7ost backports fix from OpenStack Newton to handle correctly upgraded or deleted executable.

Comment 9 errata-xmlrpc 2016-08-24 14:49:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1771.html


Note You need to log in before you can comment on or make changes to this bug.