Bug 1367346 - Unable to cherry-pick 14656 for release-3.7
Summary: Unable to cherry-pick 14656 for release-3.7
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: 3.7.14
Hardware: All
OS: All
unspecified
high
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-16 08:56 UTC by Oleksandr Natalenko
Modified: 2016-08-16 09:52 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-08-16 09:52:58 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Oleksandr Natalenko 2016-08-16 08:56:42 UTC
It is impossible to cherry-pick http://review.gluster.org/#/c/14656/ for release-3.7 branch either via Gerrit or via rfc.sh.

If performing cherry-pick with Gerrit, we get «500 Internal server error».

If doing cherry-pick via rfc.sh, push is rejected because rfc.sh thinks we are pushing to 14835 which is abandoned but has the same commit-id.

Changing commit-id fixes the issue with rfc.sh, but Poornima asked me not to do that because we want persistent commit-ids across branches.

Probably, evicting 14835 completely could fix the issue.

Comment 1 Nigel Babu 2016-08-16 09:42:52 UTC
Gerrit failing seems logical since it's detecting a second review request to do the same thing. It should handle the failure gracefully, and I'll look at what Gerrit upstream is doing about it.

We have 2 options:
a) Fix up the abandoned review.
b) Alter the Change-Id for the abandoned review. I'd really like us to do this *only* if absolutely necessary.

Poornima, can we revive the abandoned review request

Comment 2 Oleksandr Natalenko 2016-08-16 09:49:13 UTC
Agreed to stick to a).

Comment 3 Nigel Babu 2016-08-16 09:52:58 UTC
Excellent. I'll close this bug :)


Note You need to log in before you can comment on or make changes to this bug.